-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Command-Reference.md] Document new SNMP show and config commands #1600
Merged
tsvanduyn
merged 8 commits into
sonic-net:master
from
tsvanduyn:snmp_command_reference_update
May 11, 2021
Merged
[Command-Reference.md] Document new SNMP show and config commands #1600
tsvanduyn
merged 8 commits into
sonic-net:master
from
tsvanduyn:snmp_command_reference_update
May 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsvanduyn
changed the title
[show][config] SNMP commands added
[Command-Reference.md] Document new SNMP show and config commands
May 7, 2021
jleveque
suggested changes
May 7, 2021
jleveque
suggested changes
May 7, 2021
jleveque
suggested changes
May 7, 2021
jleveque
suggested changes
May 7, 2021
jleveque
suggested changes
May 7, 2021
jleveque
suggested changes
May 10, 2021
qiluo-msft
reviewed
May 10, 2021
jleveque
previously approved these changes
May 10, 2021
SuvarnaMeenakshi
approved these changes
May 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qiluo-msft
approved these changes
May 10, 2021
gitsabari
pushed a commit
to gitsabari/sonic-utilities
that referenced
this pull request
Jun 15, 2021
…nic-net#1600) * [show][config] SNMP commands added * fixed quotes for backticks * Fixed run for runningconfiguration and Del for Delete * changed admin@switch1 to admin@sonic and removed trailing prompt * updated Usage statements for SNMP * Updated for optional and required values * updated to remove unneeded example () statements * updated typo's
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 15, 2021
) * [show][config] SNMP commands added * fixed quotes for backticks * Fixed run for runningconfiguration and Del for Delete * changed admin@switch1 to admin@sonic and removed trailing prompt * updated Usage statements for SNMP * Updated for optional and required values * updated to remove unneeded example () statements * updated typo's
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
9dd3025 2021-05-11 | [Command-Reference.md] Document new SNMP show and config commands (sonic-net#1600) [Travis Van Duyn] be40767 2021-05-05 | [show][config] Add new snmp commands (sonic-net#1347) [Travis Van Duyn]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I moved SNMP from the /etc/sonic/snmp.yml file to the CONFIG_DB in this PR:
#1347
I'm just updating the Command-Reference.md to reflect those changes.
How I did it
I created new show and config commands that an installed in the CONFIG_DB
How to verify it
redis-cli -n 4 keys "*" | grep -i snmp
Previous command output (if the output of a command-line utility has changed)
The previous output was just the full snmpd.conf file.
New command output (if the output of a command-line utility has changed)
N/A