Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage uses top level directory as source #1711

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

qiluo-msft
Copy link
Contributor

@qiluo-msft qiluo-msft commented Jul 13, 2021

What I did

Originally, the Azure pipeline "Code Coverage" page will render folder structure wrongly. The first level of folders disappear and all the files in the first level are combined and de-dup. So we lost many main.py, etc.

Fix the coveragerc file so that the rendering will make sense.

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@qiluo-msft qiluo-msft changed the title Coverage uses default source config Coverage uses top level directory as source Jul 14, 2021
@qiluo-msft qiluo-msft marked this pull request as ready for review July 14, 2021 05:07
@qiluo-msft qiluo-msft requested a review from lguohan July 14, 2021 05:07
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@qiluo-msft qiluo-msft merged commit 8fe7e26 into sonic-net:master Jul 14, 2021
@qiluo-msft qiluo-msft deleted the qiluo/coverall branch July 14, 2021 05:11
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-utilities that referenced this pull request Aug 10, 2021
Originally, the Azure pipeline "Code Coverage" page will render folder structure wrongly. The first level of folders disappear and all the files in the first level are combined and de-dup. So we lost many main.py, etc.

Fix the coveragerc file so that the rendering will make sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants