Add an option in queue stat to display voq counters. #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also please add some description in PR Header |
|
This pull request introduces 1 alert when merging 781e207 into 290ff5f - view on LGTM.com new alerts:
|
|
@abdosi - reminder to re-review this PR. Thanks. |
abdosi
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added a new option in show queue counters command to display voq statistics
How I did it
Enhanced queue stat to add an option to display voq statistics. When voq option is given look
at COUNTERS_SYSTEM_PORT_NAME_MAP and COUNTERS_VOQ_NAME_MAP to derive the queue information to lookup.
Added a modified header for voq statistics.
How to verify it
Added a unit test for the new voq option. Manually verified it on a voq chassis
New command output (if the output of a command-line utility has changed)
nfc420-5|ASIC0|Cpu0 VOQ0 0 0 0 0
nfc420-5|ASIC0|Cpu0 VOQ1 0 0 0 0
nfc420-5|ASIC0|Cpu0 VOQ2 0 0 0 0
nfc420-5|ASIC0|Cpu0 VOQ3 0 0 0 0
nfc420-5|ASIC0|Cpu0 VOQ4 0 0 0 0
nfc420-5|ASIC0|Cpu0 VOQ5 0 0 0 0
nfc420-5|ASIC0|Cpu0 VOQ6 0 0 0 0
nfc420-5|ASIC0|Cpu0 VOQ7 0 0 0 0
nfc420-5|ASIC0|Ethernet0 VOQ0 0 0 0 0
nfc420-5|ASIC0|Ethernet0 VOQ1 0 0 0 0
nfc420-5|ASIC0|Ethernet0 VOQ2 0 0 0 0
nfc420-5|ASIC0|Ethernet0 VOQ3 0 0 0 0
nfc420-5|ASIC0|Ethernet0 VOQ4 0 0 0 0
nfc420-5|ASIC0|Ethernet0 VOQ5 0 0 0 0
nfc420-5|ASIC0|Ethernet0 VOQ6 0 0 0 0
nfc420-5|ASIC0|Ethernet0 VOQ7 0 0 0 0