[techsupport] [202012] Removed -i option for docker commands and Improved Error Reporting #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
qiluo-msft
reviewed
Sep 21, 2021
| @@ -1163,7 +1163,8 @@ def users(verbose): | |||
| @click.option('--verbose', is_flag=True, help="Enable verbose output") | |||
| @click.option('--allow-process-stop', is_flag=True, help="Dump additional data which may require system interruption") | |||
| @click.option('--silent', is_flag=True, help="Run techsupport in silent mode") | |||
| def techsupport(since, global_timeout, cmd_timeout, verbose, allow_process_stop, silent): | |||
| @click.option('--redirect-stderr', '-r', is_flag=True, help="Redirect an intermediate errors to STDERR") | |||
qiluo-msft
approved these changes
Sep 21, 2021
This was referenced Sep 28, 2021
yxieca
added a commit
that referenced
this pull request
Sep 28, 2021
What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 29, 2021
What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
vivekrnv
pushed a commit
to vivekrnv/sonic-utilities
that referenced
this pull request
Oct 16, 2021
…#1844) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
yxieca
pushed a commit
that referenced
this pull request
Oct 25, 2021
…oved Error Reporting (#1843) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by #1723, #1833, and #1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Nov 8, 2021
#### What I did This PR include some fixes which were missed while manually porting the error reporting PR onto 202012 #1833. i.e. removing -it option from the docker exec commands. to understand why the -it option was removed, refer #1723 This also include another fix which removes -d from the show ip interface command, which fails otherwise. **Note:** -d option for "show ip interface" is working on master and 202106. and not for 202012. So, this change is particular to 202012. Master: ``` admin@sonic-master-imge:~$ show ip interfaces -d all Interface Master IPv4 address/mask Admin/Oper BGP Neighbor Neighbor IP --------------- -------- ------------------- ------------ -------------- ------------- Loopback0 10.1.0.32/32 up/up N/A N/A PortChannel0001 10.0.0.56/31 up/up ARISTA01T1 10.0.0.57 PortChannel0002 10.0.0.58/31 up/up ARISTA02T1 10.0.0.59 PortChannel0003 10.0.0.60/31 up/up ARISTA03T1 10.0.0.61 PortChannel0004 10.0.0.62/31 up/up ARISTA04T1 10.0.0.63 Vlan1000 192.168.0.1/21 up/up N/A N/A docker0 240.127.1.1/24 up/down N/A N/A eth0 10.75.206.180/24 up/up N/A N/A lo 127.0.0.1/16 up/up N/A N/A ``` 202012: ``` admin@sonic-202012-image:~$ show ip interfaces -d all Usage: show ip interfaces [OPTIONS] Try "show ip interfaces -h" for help. Error: no such option: -d ``` #### How I did it #### How to verify it - Run the show tech-support and check the return status. It should be zero. (Atleast, it was on mellanox platform. I couldn't check the functions which were platform specific) - Run the "show techsupport" test.
praveen-li
pushed a commit
to praveen-li/sonic-utilities
that referenced
this pull request
Feb 8, 2022
…oved Error Reporting (sonic-net#1833) PR sonic-net#1723 cannot be cherry-picked directly to 202012. Thus raised a separate PR
praveen-li
pushed a commit
to praveen-li/sonic-utilities
that referenced
this pull request
Feb 8, 2022
…#1844) What I did Fix: sonic-net/sonic-buildimage#8850 Issue was introduced by sonic-net#1723, sonic-net#1833, and sonic-net#1843 (pending merge) The error_handler is a great idea but the bash script needs to be error free first. How I did it Fix bash script errors. How to verify it run show techsupport test.. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
7a58e84 [techsupport] [202012] Removed -i option for docker commands and Improved Error Reporting (sonic-net#1833)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com
What I did
PR #1723 cannot be cherry-picked directly to 202012. Thus raised a separate PR
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)