[fstrim] limit smartctl execution time to 30 seconds #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At early boot up time, smartctl is observed could stuck forever, which causes fstrim service to be stuck in pre-start state forever. This is a transient issue. The periodic retry will go through when pmon docker is healthy. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
lguohan
approved these changes
Sep 30, 2021
yxieca
added a commit
that referenced
this pull request
Oct 2, 2021
What I did At early boot up time, smartctl is observed could stuck forever, which causes fstrim service to be stuck in pre-start state forever. This is a transient issue. The periodic retry will go through when pmon docker is healthy. How to verify it This issue is not highly repeatable. Tested on the device hit the issue. Signed-off-by: Ying Xie ying.xie@microsoft.com
judyjoseph
pushed a commit
that referenced
this pull request
Oct 14, 2021
What I did At early boot up time, smartctl is observed could stuck forever, which causes fstrim service to be stuck in pre-start state forever. This is a transient issue. The periodic retry will go through when pmon docker is healthy. How to verify it This issue is not highly repeatable. Tested on the device hit the issue. Signed-off-by: Ying Xie ying.xie@microsoft.com
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
* 647f01f 2021-09-30 | [fstrim] limit smartctl execution time to 30 seconds (sonic-net#1850) (HEAD -> 202012, github/202012) [Ying Xie] * 371970e 2021-09-30 | [202012][show techsupport] address show techsupport return none zero code issue (sonic-net#1847) [Ying Xie] * 81a8386 2021-09-30 | Disable pfcwd forward action config for cisco-8000. (sonic-net#1848) [Alpesh Patel] Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
At early boot up time, smartctl is observed could stuck forever, which causes fstrim service to be stuck in pre-start state forever.
This is a transient issue. The periodic retry will go through when pmon docker is healthy.
How to verify it
This issue is not highly repeatable. Tested on the device hit the issue.
Signed-off-by: Ying Xie ying.xie@microsoft.com