Fix speed parsing when speed is NOT fetched from APPL_DB #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Junchao-Mellanox
previously approved these changes
Apr 21, 2022
stephenxs
previously approved these changes
Apr 21, 2022
…t status from STATE_DB
keboliu
dismissed stale reviews from stephenxs and Junchao-Mellanox
via
7fcc58e
liat-grozovik
approved these changes
Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kebo Liu kebol@nvidia.com
What I did
In PR #2110 introduced an enhancement to support display port speed with different unit when it is RJ45 ports, however, it only covered the case that the speed was fetched from APPL_DB.
Recently there is a change to fetch the speed from STATE_DB in some cases, the same logic also needs to be applied in this case.
How I did it
appl_db_port_speed_parseto a more generic nameport_speed_parse.port_speed_parsewhen speed is fetched from STATE_DB.How to verify it
UT and test it on platform support RJ45 ports
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)