[202111] [portchannel] Added ACL/PBH binding checks to the port before getting added to portchannel #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
dgsudharsan
approved these changes
May 26, 2022
liat-grozovik
approved these changes
May 26, 2022
dbarashinvd
pushed a commit
to dbarashinvd/sonic-utilities
that referenced
this pull request
Jul 11, 2022
…e getting added to portchannel (sonic-net#2186) - What I did Backport sonic-net#2151 to 202111 The change to handle it in oA is already added. When this check is not performed when adding the config, the portchannel configuration will be inconsistent b/w Kernel and ASIC - How I did it Utilize the match infra to implement methods to check for ACL/PBH bindings to a port - How to verify it Unit tests Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vivek Reddy Karri vkarri@nvidia.com
What I did
Backport #2151 to 202111
The change to handle it in oA is already added.
When this check is not performed when adding the config, the portchannel configuration will be inconsistent b/w Kernel and ASIC
How I did it
Utilize the match infra to implement methods to check for ACL/PBH bindings to a port
How to verify it
Unit tests
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)