[show] add new CLI to show tunnel route objects #2255

zjswhhh · 2022-07-06T01:16:14Z

What I did

Add new CLI support to show tunnel route objects in ASIC DB.

sign-off: Jing Zhang zhangjing@microsoft.com

How I did it

Check if tunnel route object exists for server_ipv4, server_ipv6, soc_ipv4. If existing, print it out.
If not specifying port name, print all tunnel route objects.

How to verify it

Added unit tests.

Tested on dual testbeds:

show mux tunnel-route Ethernet140

 PORT         DEST_TYPE    DEST_ADDRESS    
 -----------  -----------  ---------------  
 Ethernet140  server_ipv4  192.168.0.29/32

show mux tunnel-route --json Ethernet140

 {
     "TUNNEL_ROUTE": {
         "Ethernet140": {
             "server_ipv4": {
                 "DEST": "192.168.0.29/32"
             }
         }
     }
 }

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

prsunny · 2022-07-06T01:22:30Z

I tent to disagree with this change. First of all, Nexthop ID doesn't convey any meaningful information. Secondly, just "ip route show 192.168.0.29/32" will display if its tunnel or non-tunnel route.

zjswhhh · 2022-07-06T16:57:01Z

I tent to disagree with this change. First of all, Nexthop ID doesn't convey any meaningful information. Secondly, just "ip route show 192.168.0.29/32" will display if its tunnel or non-tunnel route.

Hi Prince - Yes ip route show will have that information. It's just recently we have been doing static active-active (forcing both ToR to be active) on active-standby dualToRs, and to verify the tunnel route is removed, I first need to get server ip and then check the route. So I wanted to add a CLI to check in batches. But it's not a must-have.

lgtm-com · 2022-07-06T19:46:45Z

This pull request introduces 1 alert when merging 6609452 into c7389bd - view on LGTM.com

new alerts:

1 for Unused local variable

prsunny · 2022-07-06T20:35:53Z

I tent to disagree with this change. First of all, Nexthop ID doesn't convey any meaningful information. Secondly, just "ip route show 192.168.0.29/32" will display if its tunnel or non-tunnel route.

Hi Prince - Yes ip route show will have that information. It's just recently we have been doing static active-active (forcing both ToR to be active) on active-standby dualToRs, and to verify the tunnel route is removed, I first need to get server ip and then check the route. So I wanted to add a CLI to check in batches. But it's not a must-have.

Agree, but was there an issue observed in transition that a tunnel route is not removed? I mean in active-active, there should not be any tunnel route. Just want to understand the motivation.

zjswhhh · 2022-07-06T21:48:40Z

I tent to disagree with this change. First of all, Nexthop ID doesn't convey any meaningful information. Secondly, just "ip route show 192.168.0.29/32" will display if its tunnel or non-tunnel route.

Hi Prince - Yes ip route show will have that information. It's just recently we have been doing static active-active (forcing both ToR to be active) on active-standby dualToRs, and to verify the tunnel route is removed, I first need to get server ip and then check the route. So I wanted to add a CLI to check in batches. But it's not a must-have.

Agree, but was there an issue observed in transition that a tunnel route is not removed? I mean in active-active, there should not be any tunnel route. Just want to understand the motivation.

There wasn't an issue like that. But show mux status is reflecting xcvrd/ycabled status only, and in current stage we don't care much about that, we want to have a quick way to confirm ToR is in active mode, in other words the tunnel route is removed.

show/muxcable.py

prsunny

lgtm

Update sonic-utilities submodule pointer to include the following: * [show] add new CLI to show tunnel route objects ([sonic-net#2255](sonic-net/sonic-utilities#2255)) * Add support for IP interface loopback action ([sonic-net#2192](sonic-net/sonic-utilities#2192)) * Update load minigraph to load backend acl ([sonic-net#2236](sonic-net/sonic-utilities#2236)) * show linkmgrd status in ([sonic-net#2254](sonic-net/sonic-utilities#2254)) Signed-off-by: dprital <drorp@nvidia.com>

What I did Add new CLI support to show tunnel route objects in ASIC DB. sign-off: Jing Zhang zhangjing@microsoft.com How I did it Check if tunnel route object exists for server_ipv4, server_ipv6, soc_ipv4. If existing, print it out. If not specifying port name, print all tunnel route objects. How to verify it Added unit tests. Tested on dual testbed.

qiluo-msft · 2023-02-01T20:16:34Z

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

What I did Add new CLI support to show tunnel route objects in ASIC DB. sign-off: Jing Zhang zhangjing@microsoft.com How I did it Check if tunnel route object exists for server_ipv4, server_ipv6, soc_ipv4. If existing, print it out. If not specifying port name, print all tunnel route objects. How to verify it Added unit tests. Tested on dual testbed.

What I did Add new CLI support to show tunnel route objects in APP DB. sign-off: Jing Zhang zhangjing@microsoft.com How I did it Check if tunnel route object exists for server_ipv4, server_ipv6. If existing, print it out. If not specifying port name, print all tunnel route objects. How to verify it Added unit tests. Tested on dual testbeds: show mux tunnel-route Ethernet140 PORT DEST_TYPE DEST_ADDRESS ----------- ----------- --------------- Ethernet140 server_ipv4 192.168.0.29/32 show mux tunnel-route --json Ethernet140 { "TUNNEL_ROUTE": { "Ethernet140": { "server_ipv4": { "DEST": "192.168.0.29/32" } } } }

liuh-80 · 2023-03-01T07:58:39Z

Cherry-pick PR merged: #2659

zjswhhh added 5 commits July 6, 2022 01:05

show tunnel route

370db64

show tunnel route details

d85d009

fix syntax issue

1c82d1d

add unit tests

5915ea3

update mis-used variable name

93762fc

zjswhhh requested review from vdahiya12 and yxieca July 6, 2022 18:32

zjswhhh force-pushed the asic_db_tunnel_route_master branch from 6609452 to 599215b Compare July 6, 2022 19:46

zjswhhh added 2 commits July 6, 2022 19:48

remove next hop id, update unit tests

3c0a80d

update mock table

86a9ba3

zjswhhh force-pushed the asic_db_tunnel_route_master branch from 599215b to 86a9ba3 Compare July 6, 2022 19:48

address lgtm warning

55d0ec9

yxieca previously approved these changes Jul 6, 2022

View reviewed changes

prsunny requested changes Jul 6, 2022

View reviewed changes

show/muxcable.py Outdated Show resolved Hide resolved

zjswhhh dismissed yxieca’s stale review via aa7a2f8 July 6, 2022 23:45

use APP DB table

df94706

zjswhhh force-pushed the asic_db_tunnel_route_master branch from aa7a2f8 to df94706 Compare July 7, 2022 00:18

prsunny approved these changes Jul 7, 2022

View reviewed changes

yxieca approved these changes Jul 7, 2022

View reviewed changes

zjswhhh merged commit df54138 into sonic-net:master Jul 7, 2022

zjswhhh deleted the asic_db_tunnel_route_master branch July 7, 2022 17:39

zjswhhh added the Request for 202205 Branch label Jul 7, 2022

dprital mentioned this pull request Jul 7, 2022

[submodule] Update sonic-utilities submodule sonic-net/sonic-buildimage#11379

Closed

7 tasks

yxieca added Cherry Pick Conflict_202205 Included in 202205 Branch and removed Cherry Pick Conflict_202205 labels Jul 7, 2022

zjswhhh added the Request for 202012 Branch label Jan 31, 2023

qiluo-msft added the Cherry Pick Conflict_202012 label Feb 1, 2023

zjswhhh mentioned this pull request Feb 8, 2023

[202012][show] add new CLI to show tunnel route objects #2255 #2659

Merged

zjswhhh added the Cherry Pick PR created_202012 Label for a manually cherry-pick PR created for 202012 cherry-pick conflict PR. label Feb 8, 2023

liuh-80 added the Included in 202012 Branch label Mar 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[show] add new CLI to show tunnel route objects #2255

[show] add new CLI to show tunnel route objects #2255

zjswhhh commented Jul 6, 2022 •

edited

Loading

prsunny commented Jul 6, 2022

zjswhhh commented Jul 6, 2022

lgtm-com bot commented Jul 6, 2022

prsunny commented Jul 6, 2022 •

edited

Loading

zjswhhh commented Jul 6, 2022 •

edited

Loading

prsunny left a comment

qiluo-msft commented Feb 1, 2023

liuh-80 commented Mar 1, 2023

[show] add new CLI to show tunnel route objects #2255

[show] add new CLI to show tunnel route objects #2255

Conversation

zjswhhh commented Jul 6, 2022 • edited Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

prsunny commented Jul 6, 2022

zjswhhh commented Jul 6, 2022

lgtm-com bot commented Jul 6, 2022

prsunny commented Jul 6, 2022 • edited Loading

zjswhhh commented Jul 6, 2022 • edited Loading

prsunny left a comment

Choose a reason for hiding this comment

qiluo-msft commented Feb 1, 2023

liuh-80 commented Mar 1, 2023

zjswhhh commented Jul 6, 2022 •

edited

Loading

prsunny commented Jul 6, 2022 •

edited

Loading

zjswhhh commented Jul 6, 2022 •

edited

Loading