-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vnet_route_check] Align DB data parse logic with format used by swss… #2268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…common API * swsscommon API was changed in order to return data from DB as a tuple instead of dictionary. * In some places vnet_route_check still was expecting data from DB in old format - as a dictionary. * But now it is a tuple, so as a result vnet_route_check was failing with "KeyError" exeption. * These changes fixed all the places in vnet_route_check script that used invalid data format. Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
prsunny
approved these changes
Jul 15, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Jul 20, 2022
…common API (#2268) * swsscommon API was changed in order to return data from DB as a tuple instead of dictionary. * In some places vnet_route_check still was expecting data from DB in old format - as a dictionary. * But now it is a tuple, so as a result vnet_route_check was failing with "KeyError" exeption. * These changes fixed all the places in vnet_route_check script that used invalid data format. Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
noaOrMlnx
added a commit
to noaOrMlnx/sonic-buildimage
that referenced
this pull request
Jul 20, 2022
Update sonic-utilities submodule pointer to include the following: * [vnet_route_check] Align DB data parse logic with format used by swsscommon API ([sonic-net#2268](sonic-net/sonic-utilities#2268)) * [202012] [generate_dump] allow to extend dump with plugin scripts ([sonic-net#2269](sonic-net/sonic-utilities#2269)) Signed-off-by: noaOrMlnx <noaor@nvidia.com>
7 tasks
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Jul 21, 2022
Update sonic-utilities submodule pointer to include the following: * Fix test for pfcwd_sw_enable in db_migrator_test ([sonic-net#2252](sonic-net/sonic-utilities#2252)) * [DHCPv6] [202012] Update the dhcpv6_relay config/show cli ([sonic-net#2271](sonic-net/sonic-utilities#2271)) * [vnet_route_check] Align DB data parse logic with format used by swsscommon API ([sonic-net#2268](sonic-net/sonic-utilities#2268)) * [202012] [generate_dump] allow to extend dump with plugin scripts ([sonic-net#2269](sonic-net/sonic-utilities#2269)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
yxieca
pushed a commit
that referenced
this pull request
Jul 28, 2022
…common API (#2268) * swsscommon API was changed in order to return data from DB as a tuple instead of dictionary. * In some places vnet_route_check still was expecting data from DB in old format - as a dictionary. * But now it is a tuple, so as a result vnet_route_check was failing with "KeyError" exeption. * These changes fixed all the places in vnet_route_check script that used invalid data format. Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 29, 2022
Update sonic-utilities submodule pointer to include the following: * Fix test for pfcwd_sw_enable in db_migrator_test ([#2252](sonic-net/sonic-utilities#2252)) * [DHCPv6] [202012] Update the dhcpv6_relay config/show cli ([#2271](sonic-net/sonic-utilities#2271)) * [vnet_route_check] Align DB data parse logic with format used by swsscommon API ([#2268](sonic-net/sonic-utilities#2268)) * [202012] [generate_dump] allow to extend dump with plugin scripts ([#2269](sonic-net/sonic-utilities#2269)) Signed-off-by: dprital <drorp@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…common API
Signed-off-by: Volodymyr Samotiy volodymyrs@nvidia.com
What I did
As a result of above issue vnet_route_check.py script was failing with the following exception:
How I did it
Fixed all the places in vnet_route_check script that used invalid data format: just converted data returned by swsscommon API from tuple to dictionary.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)