-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IP remove warnings for VRF commands #2351
Conversation
|
6ee4e17
to
df4a565
Compare
5cbd5ea
to
0e1b0cf
Compare
16d6658
to
3c0aece
Compare
@prsunny @qiluo-msft @dgsudharsan @preetham-singh Please review. |
looks ok to me but would like to know the motivation of the PR with such warnings? Giving such a message may fail the return value check for services invoking this function. I'll wait for @dgsudharsan and @preetham-singh to sign-off before merge? |
The intention is to print a helpful message that informs the user in case IP gets removed by the system from an interface to avoid user pit falling into an inconsistent configuration state. In my opinion, the user needs to be informed promptly to avoid ambiguity. Such helpful messages are present in other SONiC CLI commands as well. |
@prsunny @preetham-singh Please review again |
Added IP address remove warnings when performing various VRF commands i.e., - vrf bind - vrf unbind - del vrf
Added IP address remove warnings when performing various VRF commands i.e., - vrf bind - vrf unbind - del vrf
What I did
Added IP address remove warnings when performing various VRF commands i.e.,
-
vrf bind
-
vrf unbind
-
del vrf
How I did it
config/main.py
to includeclick.echo
warnings.How to verify it
Tested the changes locally by building sonic-utilities Python wheel package inside Bullseye slave container
Previous command output (if the output of a command-line utility has changed)
Example output with interface name
Ethernet0
and vrf nameVrf1
:New command output (if the output of a command-line utility has changed)
Example output with interface name
Ethernet0
and vrf nameVrf1
: