-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VxLAN]Fix Vxlan delete command to throw error when there are references #2404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ITJamie
reviewed
Sep 29, 2022
volodymyrsamotiy
approved these changes
Sep 29, 2022
prsunny
approved these changes
Sep 29, 2022
yxieca
pushed a commit
that referenced
this pull request
Oct 3, 2022
…ces (#2404) *Check for VNET references for vxlan before deleting vxlan object
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 3, 2022
…ces (#2404) *Check for VNET references for vxlan before deleting vxlan object
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Oct 11, 2022
Update sonic-utilities submodule pointer to include the following: * 94a3436 [show] vnet endpoint [ip/ipv6] command (sonic-net#2342) ([sonic-net#2421](sonic-net/sonic-utilities#2421)) * 84a0712 [VxLAN]Fix Vxlan delete command to throw error when there are references ([sonic-net#2404](sonic-net/sonic-utilities#2404)) * 1341f58 [202012] [generate_dump]: Enhance show techsupport for cisco-8000 platform ([sonic-net#2395](sonic-net/sonic-utilities#2395)) Signed-off-by: dprital <drorp@nvidia.com>
7 tasks
EdenGri
pushed a commit
to EdenGri/sonic-utilities
that referenced
this pull request
Oct 12, 2022
…ces (sonic-net#2404) *Check for VNET references for vxlan before deleting vxlan object
mdanish-kh
pushed a commit
to hamnarauf/sonic-utilities
that referenced
this pull request
Oct 22, 2022
…ces (sonic-net#2404) *Check for VNET references for vxlan before deleting vxlan object
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
…ces (sonic-net#2404) *Check for VNET references for vxlan before deleting vxlan object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for sonic-net/sonic-buildimage#12063
What I did
Check for VNET references for vxlan before deleting vxlan object
How I did it
Check VNET table and throw error if vxlan is referenced
How to verify it
Added UT to verify it.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)