Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-utilities : Added support for L2_TABLE_TYPE in acl-loader #2516

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ArthiGovindaraj
Copy link

@ArthiGovindaraj ArthiGovindaraj commented Nov 22, 2022

  • For L2 table type, modified the default rule to match any ip type
  • Added support for handling src-mac,dst-mac fields

Related pull requests:
sonic-net/sonic-swss#2554
#2516

What I did

Added L2 table type support in acl-loader utility.

How I did it

ACL supports only L3 and L3V6 table type. There is no support for matching L2 table type.
From CLICK for command "config acl update full <file.json>", provided support for L2 table type and L2 fields like src mac & dst mac.

How to verify it

  1. Create L2 Table from CLICK
    "config acl add table -s ingress -p <table_name> L2"

  2. Add rules using openconfig json format for supported fields "config acl update full/incremental <file.json>"
    "source-mac": "00:00:00:11:11:12",
    "source-mac-mask": "00:00:00:ff:ff:ff",
    "destination-mac": "00:00:00:11:11:13",
    "destination-mac-mask": "00:00:00:ff:ff:ff",
    "ethertype": "ETHERTYPE_ARP"

  3. Validate commands "show acl table"

  4. Validate commands and fields in "show acl rule"

  5. Validate commands "aclshow -a" /* Ensured that the counters are hitting the relevant rule */
    All the rules are added for each field and combinations as well. and each field tested with traffic in Broadcom based platform.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

show acl rule
L2_TABLE RULE_1 1 FORWARD DST_MAC: 00:00:00:22:22:22/00:00:00:ff:ff:ff
ETHER_TYPE: 0x0800
SRC_MAC: 00:00:00:11:11:11/00:00:00:ff:ff:ff

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

* For L2 table type, modified the default rule to match any ip type
* Added support for handling src-mac,dst-mac fields
@ArthiGovindaraj ArthiGovindaraj marked this pull request as ready for review November 28, 2022 06:50
@ArthiGovindaraj ArthiGovindaraj marked this pull request as draft December 1, 2022 10:50
@ArthiGovindaraj ArthiGovindaraj marked this pull request as ready for review December 1, 2022 10:50
@ArthiGovindaraj ArthiGovindaraj marked this pull request as draft December 5, 2022 05:29
@ArthiGovindaraj ArthiGovindaraj marked this pull request as ready for review December 5, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant