[db_migrator] Remove import of swsssdk as it is not supported in master #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
Dec 7, 2022
8 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 30, 2022
…er (#2544) Fixes: sonic-net/sonic-buildimage#12955 The cherrypick changes (from 202012 to master) made as part of #2515 broke the master branch db_migrator. The issue is due to an import of swsssdk which is no longer available in master image. How I did it Removed the import statement that came due to cherrypick. How to verify it Checked on physical device running master image Without fix: root@str2-acs-12:~# db_migrator.py Traceback (most recent call last): File "/usr/local/bin/db_migrator.py", line 11, in <module> from swsssdk import ConfigDBConnector, SonicDBConfig ModuleNotFoundError: No module named 'swsssdk' root@str2-acs-12:~# With fix: root@str2-acs-12:~# db_migrator.py version_4_0_0 root@str2-acs-12:~#
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixes: sonic-net/sonic-buildimage#12955
The cherrypick changes (from 202012 to master) made as part of #2515
broke the master branch
db_migrator. The issue is due to an import ofswsssdkwhich is no longer available in master image.How I did it
Removed the import statement that came due to cherrypick.
How to verify it
Checked on physical device running master image
Without fix:
With fix:
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)