Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "sonic-utilities: Update config reload() to verify formatting of an input file" #2595

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

ganglyu
Copy link
Contributor

@ganglyu ganglyu commented Jan 13, 2023

What I did

There are use cases like config reload /dev/stdin, for example L2 Switch mode · sonic-net/SONiC Wiki (github.com). The original PR would read input file twice, so /dev/stdin does not work.

How I did it

Reverts #2529

How to verify it

Run unit test

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@ganglyu ganglyu requested a review from StormLiangMS January 13, 2023 03:10
Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 4bd35e6 into sonic-net:202211 Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants