Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ACL table name associated with the rules and sort the output #263

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

zhenggen-xu
Copy link
Collaborator

@zhenggen-xu zhenggen-xu commented Jun 6, 2018

Add ACL table name associated with the rules and sort the output

- What I did
Add ACL table name associated with the rules
Sort the output with table name and rule name.

- How I did it
Add the code for above

- How to verify it
See test below.

- Previous command output (if the output of a command-line utility has changed)

aclshow -d
ACL Table: dataacl


Property          Value



type............  L3
policy_desc.....  dataacl
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: data-aclv6

Property          Value



type............  L3V6
policy_desc.....  data-aclv6
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Rule: Rule_2

Property          Value



PACKET_ACTION...  FORWARD
IP_TYPE.........  IPv4ANY
priority........  2000
PRIORITY........  2000
packets counter.  9
bytes counter...  3150
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Rule: Rule_1

Property          Value



PACKET_ACTION...  DROP
IP_TYPE.........  IPv6ANY
PRIORITY........  1000
packets counter.  0
bytes counter...  0
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Rule: Rule_2

Property          Value



PACKET_ACTION...  FORWARD
IP_TYPE.........  IPv6ANY
PRIORITY........  2000
packets counter.  39
bytes counter...  5424
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Rule: Rule_1

Property          Value



PACKET_ACTION...  DROP
IP_TYPE.........  IPv4ANY
priority........  1000
PRIORITY........  1000
packets counter.  0
bytes counter...  0
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 



**- New command output (if the output of a command-line utility has changed)**
aclshow -d


ACL Table: dataacl

Property          Value



type............  L3
policy_desc.....  dataacl
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: data-aclv6

Property          Value



type............  L3V6
policy_desc.....  data-aclv6
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: data-aclv6, ACL Rule: Rule_1

Property          Value



PACKET_ACTION...  DROP
IP_TYPE.........  IPv6ANY
PRIORITY........  1000
packets counter.  0
bytes counter...  0
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: data-aclv6, ACL Rule: Rule_2

Property          Value



PACKET_ACTION...  FORWARD
IP_TYPE.........  IPv6ANY
PRIORITY........  2000
packets counter.  254
bytes counter...  34948
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: data-aclv6, ACL Rule: Rule_3

Property          Value



PACKET_ACTION...  DROP
PRIORITY........  3000
SRC_IPV6........  2777::0/64
packets counter.  0
bytes counter...  0
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: data-aclv6, ACL Rule: Rule_4

Property          Value



PACKET_ACTION...  FORWARD
PRIORITY........  4000
SRC_IPV6........  2777::0/64
DST_IPV6........  2002::2/128
packets counter.  0
bytes counter...  0
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: dataacl, ACL Rule: Rule_1

Property          Value



PACKET_ACTION...  DROP
IP_TYPE.........  IPv4ANY
PRIORITY........  1000
packets counter.  0
bytes counter...  0
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: dataacl, ACL Rule: Rule_2

Property          Value



PACKET_ACTION...  FORWARD
IP_TYPE.........  IPv4ANY
PRIORITY........  2000
packets counter.  66
bytes counter...  23100
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: dataacl, ACL Rule: Rule_3

Property          Value



PACKET_ACTION...  DROP
SRC_IP..........  10.10.1.0/24
PRIORITY........  3000
packets counter.  0
bytes counter...  0
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18'] 


ACL Table: dataacl, ACL Rule: Rule_4

Property          Value



PACKET_ACTION...  FORWARD
SRC_IP..........  10.10.1.0/24
PRIORITY........  4000
DST_IP..........  10.0.1.17/32
packets counter.  0
bytes counter...  0
ports...........  ['Ethernet8', 'Ethernet9', 'Ethernet16', 'Ethernet17', 'Ethernet18']

-->

And sort the output with table name and rule name
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR comment is not well formatted.

@lguohan lguohan merged commit 3db4275 into sonic-net:master Jun 26, 2018
@zhenggen-xu zhenggen-xu deleted the github-fork-aclshow branch May 4, 2021 21:05
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
Update sonic-platform-common submodule to pick up new commits:

cd623fa [202012] Backport Enhance ssd_generic with more error handling to avoid python crash (sonic-net#273)
e9a4a81 [y_cable][Broadcom] update the BRCM y_cable driver to release 2.0 (sonic-net#263)
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
…nic-net#263)

This release goes in sync with the following firmware version of Broadcom Y cable, which is consistent with release 8
version : { "nic": "D103.2_D208.3", "tor_a": "D308.3", "tor_b": "D308.3" }


Description
Basically a vendor specific implementation of abstract YCableBase class .
detailed design discussion can be found https://github.com/Azure/SONiC/pull/757/files

Motivation and Context
to support the Y-Cable API required to support Broadcom's Y-Cable.

How Has This Been Tested?
put the changes in PMON, and all API's seem to run OK.

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants