[dns] Implement config and show commands for static DNS. #2737

oleksandrivantsiv · 2023-03-14T13:22:23Z

What I did

Implement config and show commands for static DNS feature. According to sonic-net/SONiC#1262 HLD.

How I did it

Static DNS config commands are implemented in the new config/dns.py file. DNS config commands are available under config dns ... sub-command.
Show commands are implemented in the new show/dns.py file. DNS show commands are available under show dns ... sub-command.

How to verify it

Compile sonic-utilities package. The unit tests will run automatically during the compilation.
Coverage for config/dns.py : 94%
Coverage for show/dns.py : 86%

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

# config dns nameserver add 1.1.1.1
# config dns nameserver add 8.8.8.8
# show dns nameserver
  Nameserver
------------
     1.1.1.1
     8.8.8.8

isabelmsft

Hi @oleksandrivantsiv , thanks for your work on this PR and the DNS yang model.

Since we are in the process of replacing adhoc validation checks (like your function def is_valid_ip_address) with yang validation, could you please update your PR to reflect this?

Here is the design doc for how we are phasing in yang validation: sonic-net/SONiC#1072

Here is a sample PR to demonstrate changes that would be necessary to your PR: #2604

On a high level, the main steps are:

add if ADHOC_VALIDATION: where you currently have adhoc validation
use the ValidatedConfigDBConnector decorator

Implement unit tests for all added commands. Coverage for config/dns.py : 94% Coverage for show/dns.py : 86%

oleksandrivantsiv · 2023-06-08T10:53:56Z

Hi @oleksandrivantsiv , thanks for your work on this PR and the DNS yang model.

Since we are in the process of replacing adhoc validation checks (like your function def is_valid_ip_address) with yang validation, could you please update your PR to reflect this?

Here is the design doc for how we are phasing in yang validation: sonic-net/SONiC#1072

Here is a sample PR to demonstrate changes that would be necessary to your PR: #2604

On a high level, the main steps are:

add if ADHOC_VALIDATION: where you currently have adhoc validation

use the ValidatedConfigDBConnector decorator

@isabelmsft done

liat-grozovik · 2023-06-14T07:58:57Z

@isabelmsft could you please help to review following comments handled?

oleksandrivantsiv · 2023-06-21T15:04:14Z

@isabelmsft kindly reminder to review

liat-grozovik · 2023-06-21T15:41:58Z

@zhangyanzhao as this should be part of 202305 can you please create a label for sonic-utilities?

liat-grozovik

@oleksandrivantsiv you are missing the command line reference update with the new commands. can you please update it and add the changes to this PR

oleksandrivantsiv · 2023-06-22T17:39:27Z

@oleksandrivantsiv you are missing the command line reference update with the new commands. can you please update it and add the changes to this PR

done

Update sonic-utilities submodule pointer to include the following: * ff380e04 [hash]: Implement GH frontend ([sonic-net#2580](sonic-net/sonic-utilities#2580)) * 61bad064 [db_migrator] Set correct CURRENT_VERSION, extend UT ([sonic-net#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47c [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([sonic-net#2885](sonic-net/sonic-utilities#2885)) * 73d8d633 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([sonic-net#2750](sonic-net/sonic-utilities#2750)) * 7bc08c28 [db_migrator] Remove hardcoded config and migrate config from minigraph ([sonic-net#2887](sonic-net/sonic-utilities#2887)) * b1aa9426 [generate_dump]: Enhance show techsupport for Marvell platform ([sonic-net#2676](sonic-net/sonic-utilities#2676)) * 316b14c0 Add support for secure upgrade ([sonic-net#2698](sonic-net/sonic-utilities#2698)) * dc2945bc [dns] Implement config and show commands for static DNS. ([sonic-net#2737](sonic-net/sonic-utilities#2737)) * 8414a709 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([sonic-net#2525](sonic-net/sonic-utilities#2525)) * 0b629ba1 Revert [chassis][voq] Clear fabric counters queue/port (2789) ([sonic-net#2882](sonic-net/sonic-utilities#2882)) * 3ba8241a [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([sonic-net#2839](sonic-net/sonic-utilities#2839)) * fceef2ed [chassis][voq] Clear fabric counters queue/port ([sonic-net#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>

Update sonic-utilities submodule pointer to include the following: * ff380e04 [hash]: Implement GH frontend ([#2580](sonic-net/sonic-utilities#2580)) * 61bad064 [db_migrator] Set correct CURRENT_VERSION, extend UT ([#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47c [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([#2885](sonic-net/sonic-utilities#2885)) * 73d8d633 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([#2750](sonic-net/sonic-utilities#2750)) * 7bc08c28 [db_migrator] Remove hardcoded config and migrate config from minigraph ([#2887](sonic-net/sonic-utilities#2887)) * b1aa9426 [generate_dump]: Enhance show techsupport for Marvell platform ([#2676](sonic-net/sonic-utilities#2676)) * 316b14c0 Add support for secure upgrade ([#2698](sonic-net/sonic-utilities#2698)) * dc2945bc [dns] Implement config and show commands for static DNS. ([#2737](sonic-net/sonic-utilities#2737)) * 8414a709 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([#2525](sonic-net/sonic-utilities#2525)) * 0b629ba1 Revert [chassis][voq] Clear fabric counters queue/port (2789) ([#2882](sonic-net/sonic-utilities#2882)) * 3ba8241a [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([#2839](sonic-net/sonic-utilities#2839)) * fceef2ed [chassis][voq] Clear fabric counters queue/port ([#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>

) - What I did Implement config and show commands for static DNS feature. According to sonic-net/SONiC#1262 HLD. - How I did it Static DNS config commands are implemented in the new config/dns.py file. DNS config commands are available under config dns ... sub-command. Show commands are implemented in the new show/dns.py file. DNS show commands are available under show dns ... sub-command. - How to verify it Compile sonic-utilities package. The unit tests will run automatically during the compilation. Coverage for config/dns.py : 94% Coverage for show/dns.py : 86% - Previous command output (if the output of a command-line utility has changed) - New command output (if the output of a command-line utility has changed) # config dns nameserver add 1.1.1.1 # config dns nameserver add 8.8.8.8 # show dns nameserver Nameserver ------------ 1.1.1.1 8.8.8.8

Update sonic-utilities submodule pointer to include the following: * ff380e04 [hash]: Implement GH frontend ([sonic-net#2580](sonic-net/sonic-utilities#2580)) * 61bad064 [db_migrator] Set correct CURRENT_VERSION, extend UT ([sonic-net#2895](sonic-net/sonic-utilities#2895)) * 6b8ee47c [CLI][Show][BGP] Show BGP Change for no neighbor scenario ([sonic-net#2885](sonic-net/sonic-utilities#2885)) * 73d8d633 [doc] Update Command-Reference.md, change show bgp peer command to show bfd peer ([sonic-net#2750](sonic-net/sonic-utilities#2750)) * 7bc08c28 [db_migrator] Remove hardcoded config and migrate config from minigraph ([sonic-net#2887](sonic-net/sonic-utilities#2887)) * b1aa9426 [generate_dump]: Enhance show techsupport for Marvell platform ([sonic-net#2676](sonic-net/sonic-utilities#2676)) * 316b14c0 Add support for secure upgrade ([sonic-net#2698](sonic-net/sonic-utilities#2698)) * dc2945bc [dns] Implement config and show commands for static DNS. ([sonic-net#2737](sonic-net/sonic-utilities#2737)) * 8414a709 [chassis][multi asic] change acl_loader to use tcp socket for db communication ([sonic-net#2525](sonic-net/sonic-utilities#2525)) * 0b629ba1 Revert [chassis][voq] Clear fabric counters queue/port (2789) ([sonic-net#2882](sonic-net/sonic-utilities#2882)) * 3ba8241a [db_migtrator] Add migration of FLEX_COUNTER_DELAY_STATUS during 1911->master upgrade + fast-reboot. Add UT. ([sonic-net#2839](sonic-net/sonic-utilities#2839)) * fceef2ed [chassis][voq] Clear fabric counters queue/port ([sonic-net#2789](sonic-net/sonic-utilities#2789)) Signed-off-by: dgsudharsan <sudharsand@nvidia.com>

Yakiv-Huryk previously approved these changes Mar 14, 2023

View reviewed changes

oleksandrivantsiv mentioned this pull request Mar 16, 2023

Static DNS HLD sonic-net/SONiC#1262

Merged

oleksandrivantsiv marked this pull request as draft March 21, 2023 08:38

qiluo-msft requested a review from isabelmsft April 7, 2023 21:43

isabelmsft requested changes Apr 8, 2023

View reviewed changes

ganglyu previously approved these changes Apr 15, 2023

View reviewed changes

oleksandrivantsiv dismissed stale reviews from ganglyu and Yakiv-Huryk via 52baf8a May 30, 2023 09:36

oleksandrivantsiv force-pushed the master branch from c2fd9b9 to 52baf8a Compare May 30, 2023 09:36

[dns] Implement config and show commands for static DNS.

986f60e

Implement unit tests for all added commands. Coverage for config/dns.py : 94% Coverage for show/dns.py : 86%

oleksandrivantsiv force-pushed the master branch from 52baf8a to 986f60e Compare May 30, 2023 11:01

oleksandrivantsiv marked this pull request as ready for review June 8, 2023 10:53

isabelmsft previously approved these changes Jun 21, 2023

View reviewed changes

Yakiv-Huryk approved these changes Jun 22, 2023

View reviewed changes

liat-grozovik requested changes Jun 22, 2023

View reviewed changes

Update command reference document with static DNS feature commands.

6e27880

oleksandrivantsiv dismissed isabelmsft’s stale review via 6e27880 June 22, 2023 17:36

Update modification date of command reference document.

44f7bef

dgsudharsan approved these changes Jun 23, 2023

View reviewed changes

liat-grozovik approved these changes Jun 25, 2023

View reviewed changes

liat-grozovik merged commit dc2945b into sonic-net:master Jun 25, 2023
4 checks passed

liat-grozovik added the Request for 202305 Branch label Jun 25, 2023

dgsudharsan mentioned this pull request Jul 11, 2023

[submodule] Advance sonic-utilities pointer sonic-net/sonic-buildimage#15779

Merged

11 tasks

oleksandrivantsiv removed the Request for 202305 Branch label Sep 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[dns] Implement config and show commands for static DNS. #2737

[dns] Implement config and show commands for static DNS. #2737

oleksandrivantsiv commented Mar 14, 2023

isabelmsft left a comment •

edited

Loading

oleksandrivantsiv commented Jun 8, 2023

liat-grozovik commented Jun 14, 2023

oleksandrivantsiv commented Jun 21, 2023

liat-grozovik commented Jun 21, 2023

liat-grozovik left a comment

oleksandrivantsiv commented Jun 22, 2023

[dns] Implement config and show commands for static DNS. #2737

[dns] Implement config and show commands for static DNS. #2737

Conversation

oleksandrivantsiv commented Mar 14, 2023

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

isabelmsft left a comment • edited Loading

Choose a reason for hiding this comment

oleksandrivantsiv commented Jun 8, 2023

liat-grozovik commented Jun 14, 2023

oleksandrivantsiv commented Jun 21, 2023

liat-grozovik commented Jun 21, 2023

liat-grozovik left a comment

Choose a reason for hiding this comment

oleksandrivantsiv commented Jun 22, 2023

isabelmsft left a comment •

edited

Loading