-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to display the SONiC OS Version in the command show version #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
xumia
force-pushed
the
support-sonic-os-version
branch
from
April 11, 2023 13:35
d3a7047
to
42f0681
Compare
xumia
force-pushed
the
support-sonic-os-version
branch
from
April 11, 2023 14:12
42f0681
to
7983211
Compare
qiluo-msft
reviewed
Apr 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lguohan , could you please help review it? Thanks. |
lguohan
approved these changes
Apr 12, 2023
yxieca
pushed a commit
that referenced
this pull request
Apr 19, 2023
…2787) What I did Support to display the SONiC OS Version in the command show version. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 How I did it The device info is in sonic-net/sonic-buildimage, see PR: sonic-net/sonic-buildimage#14601 The submodule change can be merged to sonic-buildimage, after the PR 14601 merged. How to verify it
StormLiangMS
pushed a commit
that referenced
this pull request
Apr 20, 2023
…2787) What I did Support to display the SONiC OS Version in the command show version. It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version. SONiC Software Version: SONiC.master-13812.218661-7d94c0c28 SONiC OS Version: 11 Distribution: Debian 11.6 Kernel: 5.10.0-18-2-amd64 How I did it The device info is in sonic-net/sonic-buildimage, see PR: sonic-net/sonic-buildimage#14601 The submodule change can be merged to sonic-buildimage, after the PR 14601 merged. How to verify it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Support to display the SONiC OS Version in the command show version.
It will be used to display the version info in the SONiC command "show version". The version is used to do the FIPS certification. We do not do the FIPS certification on a specific release, but on the SONiC OS Version.
How I did it
The device info is in sonic-net/sonic-buildimage, see PR: sonic-net/sonic-buildimage#14601
The submodule change can be merged to sonic-buildimage, after the PR 14601 merged.
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)