Update consutil for picocom v1.7 #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect skeletons Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
…nd connect line Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
Get flow control in addition to baud rate Get line number for a specific device name from config db Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
fix picocom ready message, fix regex for date in getBusyDevices, change default picocom output, change comments Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
…o connect-line Add connect line entry point code # Conflicts: # consutil/lib.py
Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
…commands Use pexpect for run_command instead of subprocess Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
Add all macros to top of file, getConnectionInfo returns actual baud rate, configured baud rate, and flow control getLineNumber used for all targets (line numbers and device names) Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
getConnectionInfo returns actual baud, configured baud, and flow control for show(), align baud rates by "/" clean up connect() and remove macros Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
…o connect-line # Conflicts: # consutil/lib.py # consutil/main.py Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
…files Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
|
what's the nature of this change? is it because -q is not supported by picocom? |
|
Yes - originally I developed consutil using picocom v3, but now we're using picocom v1.7, which doesn't have the -q flag and uses /var/lock files |
jleveque
suggested changes
Aug 16, 2018
consutil/main.py
Outdated
| @@ -62,6 +62,8 @@ def clear(linenum): | |||
| cmd = "sudo kill -SIGTERM " + pid | |||
| click.echo("Sending SIGTERM to process " + pid) | |||
| run_command(cmd) | |||
| cmd = "sudo rm /var/lock/LCK..ttyUSB" + linenum | |||
There was a problem hiding this comment.
Suggest to add -f flag to rm command to help ensure file is deleted.
Signed-off-by: Cayla Wanderman-Milne <t-cawand@microsoft.com>
lguohan
requested changes
Aug 17, 2018
|
We can delete this PR since the base image has picocom v3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Updated consutil for picocom v1.7 by removing QUIET flag and accounting for /var/lock files
- How I did it
Removed any code that used QUIET flag. Added code in
clear()that removes /var/lock/LCK..ttyUSB file- How to verify it
Run
connect line <linenumber>orconnect device <devicename>andclear line <linenumber>on device with picocom v1.7. Ensure that you can successfully connect to devices, that you get an error for trying to connect to a busy device, and thatclearsuccessfully clears a busy line.-->