Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCU support for Cisco-8000 features #3010

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

rbpittman
Copy link
Contributor

@rbpittman rbpittman commented Oct 11, 2023

What I did

Fill in several "Unknown" fields in the table from PR #2791 for Cisco-8000.

How I did it

How to verify it

Verified test pass for test_pg_headroom_update.py

Previous command output (if the output of a command-line utility has changed)

When trying to apply a patch to update the xoff field for a lossless buffer profile:

$ config apply-patch /home/cisco/patch.json
Patch Applier: Patch application starting.
Patch Applier: Patch: [{"value": "440600", "op": "replace", "path": "/BUFFER_PROFILE/pg_lossless_100000_5m_profile/xoff"}]
Patch Applier: Getting current config db.
Patch Applier: Simulating the target full config after applying the patch.
Patch Applier: Validating all JsonPatch operations are permitted on the specified fields
Failed to apply patch
Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH
Try "config apply-patch -h" for help.

Error: Modification of BUFFER_PROFILE table is illegal- validating function generic_config_updater.field_operation_validators.rdma_config_update_validator returned False

New command output (if the output of a command-line utility has changed)

$ config apply-patch /home/cisco/patch.json
Patch Applier: Patch application starting.
Patch Applier: Patch: [{"value": "440600", "op": "replace", "path": "/BUFFER_PROFILE/pg_lossless_100000_5m_profile/xoff"}]
Patch Applier: Getting current config db.
Patch Applier: Simulating the target full config after applying the patch.
Patch Applier: Validating all JsonPatch operations are permitted on the specified fields
Patch Applier: Validating target config does not have empty tables, since they do not show up in ConfigDb.
Patch Applier: Sorting patch updates.
Patch Applier: The patch was sorted into 1 change:
Patch Applier:   * [{"op": "replace", "path": "/BUFFER_PROFILE/pg_lossless_100000_5m_profile/xoff", "value": "440600"}]
Patch Applier: Applying 1 change in order:
Patch Applier:   * [{"op": "replace", "path": "/BUFFER_PROFILE/pg_lossless_100000_5m_profile/xoff", "value": "440600"}]
Patch Applier: Verifying patch updates are reflected on ConfigDB.
Patch Applier: Patch application completed.
Patch applied successfully.

@rbpittman rbpittman marked this pull request as ready for review November 9, 2023 21:16
Copy link

@wsycqyz wsycqyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinskwang kevinskwang merged commit f1e24ae into sonic-net:master Nov 15, 2023
5 checks passed
StormLiangMS pushed a commit that referenced this pull request Nov 16, 2023
* GCU support for Cisco-8000 for shared/headroom pool size, dynamic th change, xoff change.

* Support ECN GCU.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants