Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added argument forwarder for platform reboot. #333

Merged
merged 2 commits into from
Oct 5, 2018

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Oct 2, 2018

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

- What I did

  1. Fixed Mellanox fast reboot script
  2. Added argument forwarder for platform reboot

- How I did it

  • N/A

- How to verify it
To verify fast reboot:

  1. Run fast reboot

To verify argument forwarding:

  1. Pass custom arguments to platform reboot script

- Previous command output (if the output of a command-line utility has changed)

  • N/A

- New command output (if the output of a command-line utility has changed)

  • N/A

- External dependencies

  1. Fixed FW upgrade sequence. sonic-buildimage#2111

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@qiluo-msft qiluo-msft merged commit 4258287 into sonic-net:master Oct 5, 2018
mihirpat1 pushed a commit to mihirpat1/sonic-utilities that referenced this pull request Sep 15, 2023
…d in the eepromTlvInfo decode (sonic-net#333)

Description
The VEMDOR_EXT field parse the data and format each in byte in hex with space as separator. But the logic leaves a space at the end of the value. This PR removes the trailing space in output of the VENDOR_EXT field in the eepromTlvInfo decode

This change is needed by 202205 branch

Motivation and Context
The trailing space at end of the VENDOR_EXT field cause the test of function get_system_eeprom_info() failed. The trailing space of the data filed is invisible char in the show platform syseeprom output while the get_system_eeprom_info() return a dictionary with trailing space in the end. This results in a mis-matched in the test case.

Signed-off-by: mlok <marty.lok@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants