Adds logic to get default disk and check disk type #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assrinivasan
requested review from
saiarcot895,
prgeor,
vdahiya12,
mihirpat1 and
vvolam
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vvolam
reviewed
Jul 8, 2024
keboliu
reviewed
Jul 31, 2024
The syslogger-to-logger change is unrelated to the sonic-utilities change and breaks backwards compatibility. It should be a separate commit once SysLogger is in all the older versions.
Open
8 tasks
|
@prgeor please help review/merge. Thanks. |
keboliu
reviewed
Sep 10, 2024
keboliu
approved these changes
Sep 10, 2024
prgeor
reviewed
Sep 23, 2024
Comment on lines
+82
to
+88
| from sonic_platform_base.sonic_ssd.ssd_generic import SsdUtil | ||
| except ImportError as e: | ||
| log.log_error("Failed to import default SsdUtil. Error: {}".format(str(e)), True) | ||
| raise e | ||
| try: | ||
| from sonic_platform_base.sonic_storage.ssd import SsdUtil | ||
| except ImportError as e: | ||
| log.log_error("Failed to import default SsdUtil. Error: {}".format(str(e)), True) # noqa: E501 | ||
| raise e |
There was a problem hiding this comment.
@assrinivasan why we need two different SsdUtil implementation?
There was a problem hiding this comment.
I was going to say to maintain backwards compatibility, but since you said we should only take this into master and 202405+, there is no need for SsdUtil anymore. I will therefore change this to just import StorageUtil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fix for sonic-buildimage issue 9407
To be merged
How I did it
Added logic using python libraries blkinfo and psutil to get the default disk, and the disk type (SATA/non-SATA).
How to verify it
call
sudo ssdutilon a device with non-SATA disk (such as EUSB). Expected output is:Also ran a modified test_show_platform_ssdhealth (See sonic-mgmt PR mentioned above) on switches with all 4 disk types and verified that test was either skipped or passed. Logs attached: test_show_platform_ssdhealth.txt
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)