-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Add remote compatible show ip bgp and -n all for show ip bgp network #3413
[Draft] Add remote compatible show ip bgp and -n all for show ip bgp network #3413
Conversation
… show ip bgp network
ctx.fail('-n/--namespace option required. provide namespace from list {}'\ | ||
.format(multi_asic.get_namespace_list())) | ||
namespace = namespace.strip() | ||
if multi_asic.is_multi_asic(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you are just keeping original logic here, that if it is multi-asic, and namespace is not provided, error out.
but I think original logic may not be updated, can you change to: if multi asic, and namespace is not provided, print for all asics?
refer to: #2427
another pros for this is, you are running this cmd on sup, if one chassis has both multi/single-asic LCs, show ip bgp sum
will output for all LCs, instead of having multi-asic LC error out, in this case we could have at least cmd working for both multi/single-asic.
What I did
I enable the direct execution of "show ip bgp" on chassis supervisor and "-n all" option for "show ip bgp network" on multi-asic machine
How I did it
How to verify it
On chassis supervisor, run "show ip bgp ..."
On a multi-asic device, run "show ip bgp network -n all"
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)