Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine multiple database write operations into one for ecnconfig #3452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhixzhu
Copy link
Contributor

@zhixzhu zhixzhu commented Jul 26, 2024

What I did

Update the ecnconfig to optimize the configuration by not having to update per attribute configured.

How I did it

Combine multiple database write operations into one.

How to verify it

Verified it on testbed.
Reduce the time from 7 seconds to 3 seconds according to file sairedis.asic0.rec.

Old log:

sudo ip netns exec asic0 ecnconfig -p AZURE_LOSSLESS -gmin 1048576 -gmax 4194304 -gdrop 5 // 7 seconds

2024-07-25.22:56:32.456074|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_ECN_MARK_MODE=SAI_ECN_MARK_MODE_GREEN_YELLOW
2024-07-25.22:56:32.956405|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_DROP_PROBABILITY=100
2024-07-25.22:56:33.460428|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_MAX_THRESHOLD=4194304
2024-07-25.22:56:34.020608|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_MIN_THRESHOLD=1048576
2024-07-25.22:56:34.537116|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_ENABLE=true
2024-07-25.22:56:34.596754|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_ENABLE=true
2024-07-25.22:56:34.597617|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_DROP_PROBABILITY=0
2024-07-25.22:56:35.127506|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_MAX_THRESHOLD=6144000
2024-07-25.22:56:35.674162|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_MIN_THRESHOLD=0

2024-07-25.22:56:36.357615|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_ECN_MARK_MODE=SAI_ECN_MARK_MODE_GREEN_YELLOW
2024-07-25.22:56:36.918050|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_DROP_PROBABILITY=5
2024-07-25.22:56:37.564106|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_MAX_THRESHOLD=4194304
2024-07-25.22:56:38.064905|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_MIN_THRESHOLD=1048576
2024-07-25.22:56:38.676530|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_ENABLE=true
2024-07-25.22:56:38.695258|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_ENABLE=true
2024-07-25.22:56:38.696198|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_DROP_PROBABILITY=0
2024-07-25.22:56:39.193380|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_MAX_THRESHOLD=6144000
2024-07-25.22:56:39.733325|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_MIN_THRESHOLD=0

New log:

sudo ip netns exec asic0 ecnconfig -p AZURE_LOSSLESS -gmin 1048576 -gmax 4194304 -gdrop 5 // 3 seconds

2024-07-26.00:23:21.509712|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_ECN_MARK_MODE=SAI_ECN_MARK_MODE_GREEN_YELLOW
2024-07-26.00:23:21.985441|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_DROP_PROBABILITY=5
2024-07-26.00:23:22.473747|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_MAX_THRESHOLD=4194304
2024-07-26.00:23:23.054270|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_MIN_THRESHOLD=1048576
2024-07-26.00:23:23.603101|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_GREEN_ENABLE=true
2024-07-26.00:23:23.657349|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_ENABLE=true
2024-07-26.00:23:23.657825|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_DROP_PROBABILITY=0
2024-07-26.00:23:24.155250|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_MAX_THRESHOLD=6144000
2024-07-26.00:23:24.682135|s|SAI_OBJECT_TYPE_WRED:oid:0x130000000006ae|SAI_WRED_ATTR_YELLOW_MIN_THRESHOLD=0

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Zhixin Zhu <zhixzhu@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant