-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up route_check script #3544
Speed up route_check script #3544
Conversation
@anamehra , could you try this change and see if this helps? Thanks! |
LGTM Validated on Cisco T2 LC: Without change: With this change: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes looks good. Can you confirm if this script works properly on single asic device?
Thanks @arlakshm . Verified on single asic device. it works fine. |
@arlakshm could you help re review and merge? Thanks |
@deepak-singhal0408 Can you raise a PR to 202405 to address conflict? |
What I did
This PR fixes sonic-net/sonic-buildimage#18773
How I did it
Parallely execute route_check on each Asic.
Parallelly fetch ipv4 routes and ipv6 routes.
How to verify it
execute "time route_check.py" on T2 chassis having 32k v4+32k v6 routes.
Results:
Before:
Checking routes for namespaces: ['asic0', 'asic1']
real 3m16.387s
user 1m26.084s
sys 0m7.275s
After:
time route_check.py
real 1m30.675s
user 1m33.777s
sys 0m8.209s
Previous command output (if the output of a command-line utility has changed)
None
New command output (if the output of a command-line utility has changed)
None