Fix multi-asic behaviour for queuestat

[arista-hpandya]

What I did

• Added support for iterating over all namespaces (ns) when none specified
• Added a test case to verify all ns behaviour
• Introduced a wrapper class to handle the mutli-asic functionality
• Replaced argparse with click for better argument checks

This is in accordance to the issue sonic-net/sonic-buildimage#15148 which tracks the multi-asic support for scripts in sonic-utilities.

How I did it

Modified the queuestat script and associated test files.

How to verify it

The changes were verified by:

• Running all the unit tests in conic-utilities
• Verifying the changes manually on a T2 single-asic linecard
• Verifying the changes manually on a multi-asic linecard

Previous command output (if the output of a command-line utility has changed)

Cmd: queuestat
Result: Empty

Reason: When the namespace (-n/--namespace) argument is not specified on a multi asic device the scripts will return nothing.

New command output (if the output of a command-line utility has changed)

Cmd: queuestat
Result: Runs on all asics present on the device.

Reason: To be consistent with the other PRs in #15148, we iterate over all namespaces when none is specified on a multi-asic device.

Test snapshots provided below:

Specifying invalid namespace on single asic devices: queuestat -n asic0

Single asic behaviour is preserved: queuestat -p Ethernet152

Multi asic behaviour when namespace is specified: queuestat -n asic1 -p Ethernet-Rec1

Multi asic behaviour when no namespace is specified: queuestat

.
.
.

.
.
.

[kenneth-arista]

@wenyiz2021 @arlakshm @vmittal-msft

[wenyiz2021]

result LGTM, haven't check code details

[arista-hpandya]

@wenyiz2021 Can we add the backport template in the PR description similar to sonic-mgmt? This will help to remind us to mention the branches the change should be cherry-picked in when opening a PR in the future.

Back port request

• 202012
• 202205
• 202305
• 202311
• 202405

[vmittal-msft]

LGTM. Did we verify single asic box to make sure it is still good ? If so, we can merge.

[arista-hpandya]

LGTM. Did we verify single asic box to make sure it is still good ? If so, we can merge.

Yes, single asic snapshots are attached in the PR description.

[mssonicbld]

Cherry-pick PR to 202405: #3635

[auspham]

Hi @vmittal-msft @arista-hpandya, we suspect that this PR could potentially led to the issue mentioned here:

sonic-net/sonic-mgmt#15949

Could you please advise if this is the expected fix. Thanks

[arista-hpandya]

@auspham This PR was built on the philosophy that when no namespace is mentioned, all namespaces are considered. This behaviour also sustains if you use sudo ip netns command. Note that the later is an old way of selecting namespaces and we wish to move away from it.

For clarity:
CMD: sudo ip netns exec asic1 show queue counters Ethernet128
Output:

For namespace asic0:
       Port    TxQ    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes
-----------  -----  --------------  ---------------  -----------  ------------
Ethernet128    UC0               0                0            0             0
Ethernet128    UC1               0                0            0             0
Ethernet128    UC2               0                0            0             0
Ethernet128    UC3               0                0            0             0
Ethernet128    UC4               0                0            0             0
Ethernet128    UC5               0                0            0             0
Ethernet128    UC6               0                0            0             0
Ethernet128    UC7           96670         10071667            0             0
Ethernet128    MC8               0                0            0             0
Ethernet128    MC9               0                0            0             0
Ethernet128   MC10               0                0            0             0
Ethernet128   MC11               0                0            0             0
Ethernet128   MC12               0                0            0             0
Ethernet128   MC13               0                0            0             0
Ethernet128   MC14               0                0            0             0
Ethernet128   MC15               0                0            0             0

Port doesn't exist! Ethernet128

Note above how we got the expected output on asic 0 but since the interface was absent on asic1 it raised an error. Additionally the sudo ip netns command to choose asic1 was ignored because we no longer support it.

For completeness, the ideal way to. use this command would be:
CMD: show queue counters Ethernet128 -n asic0
Output:

For namespace asic0:
       Port    TxQ    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes
-----------  -----  --------------  ---------------  -----------  ------------
Ethernet128    UC0               0                0            0             0
Ethernet128    UC1               0                0            0             0
Ethernet128    UC2               0                0            0             0
Ethernet128    UC3               0                0            0             0
Ethernet128    UC4               0                0            0             0
Ethernet128    UC5               0                0            0             0
Ethernet128    UC6               0                0            0             0
Ethernet128    UC7           96714         10075797            0             0
Ethernet128    MC8               0                0            0             0
Ethernet128    MC9               0                0            0             0
Ethernet128   MC10               0                0            0             0
Ethernet128   MC11               0                0            0             0
Ethernet128   MC12               0                0            0             0
Ethernet128   MC13               0                0            0             0
Ethernet128   MC14               0                0            0             0
Ethernet128   MC15               0                0            0             0

CMD: show queue counters Ethernet128 -n asic1
Output:

Port doesn't exist! Ethernet128

[auspham]

Thanks for the clear and detail response @arista-hpandya . @yejianquan for viz