show interface status <interface-name> throws error (fixes #427) #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface status A bug in intfutil script that gets the keys object from the app-db for a specific interface Signed-off-by: kiran.kella@broadcom.com
…stead of the optional alias attribute * Addressed review comment for sonic-net#424 * Undone the change in intfutil file to push that fix in a seperate PR. Signed-off-by: kiran.kella@broadcom.com
…c interface. * While getting the keys from port table for a specific interface, wrong db is passed, fixed the bug Signed-off-by: kiran.kella@broadcom.com
…erface-name> startup/shutdown'.
…c interface. * While getting the keys from port table for a specific interface, wrong db is passed, fixed the bug Signed-off-by: kiran.kella@broadcom.com
…nic-utilities into show_intf_specific
kirankella
changed the title
|
Retest this please |
Retested to be working fine. |
Closed
lguohan
approved these changes
Mar 7, 2019
yxieca
pushed a commit
that referenced
this pull request
Mar 19, 2019
* sonic-utilities: Bug fix while showing interface status for a specific interface. * While getting the keys from port table for a specific interface, wrong db is passed, fixed the bug Signed-off-by: kiran.kella@broadcom.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Wrong db variable is passed when getting the keys for a particular interface from app-db.
- How I did it
Pass the proper db variable in intfutil when getting the keys for a particular interface from app-db.
- How to verify it
show interface status Ethernet0
- Previous command output (if the output of a command-line utility has changed)
root@sonic:/home/admin# show interface status Ethernet0
Traceback (most recent call last):
File "/usr/bin/intfutil", line 204, in
main(sys.argv[1:])
File "/usr/bin/intfutil", line 197, in main
interface_stat = IntfStatus(intf_name)
File "/usr/bin/intfutil", line 129, in init
appl_db_keys = appl_db_keys_get(self.appl_db, intf_name)
File "/usr/bin/intfutil", line 41, in appl_db_keys_get
appl_db_keys = db.keys(appl_db.APPL_DB, "PORT_TABLE:%s" % intf_name)
NameError: global name 'db' is not defined
- New command output (if the output of a command-line utility has changed)
root@sonic:/home/admin# show interface status Ethernet0
Interface Lanes Speed MTU Alias Oper Admin Type
Ethernet0 13 N/A 9100 tenGigE0 up up SFP
-->