Allow config shutdown and startup operations on valid PortChannel interface names #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface status A bug in intfutil script that gets the keys object from the app-db for a specific interface Signed-off-by: kiran.kella@broadcom.com
…stead of the optional alias attribute * Addressed review comment for sonic-net#424 * Undone the change in intfutil file to push that fix in a seperate PR. Signed-off-by: kiran.kella@broadcom.com
…erface-name> startup/shutdown'.
…terface names Signed-off-by: Kiran Kella <kiran.kella@broadcom.com>
jleveque
approved these changes
Feb 28, 2019
|
It doesn't appear as though the |
jleveque
suggested changes
Mar 28, 2019
|
@kirankella Could you response to @jleveque 's request? |
yxieca
approved these changes
Mar 28, 2019
…e alias names of PORTs. Signed-off-by: Kiran Kella <kiran.kella@broadcom.com>
@jleveque Added interface naming mode support to the config startup/shutdown commands. |
jleveque
approved these changes
Mar 28, 2019
yxieca
pushed a commit
that referenced
this pull request
Mar 30, 2019
…erface names (#474) * Avoid shutdown/startup commands on invalid interface names * sonic-utilities: Fix bug in the show command to display a specific interface status * sonic-utilities: Check for the presence of interface in port table instead of the optional alias attribute * Addressed review comment for #424 * Undone the change in intfutil file to push that fix in a seperate PR. * Corrected the error message string for 'config interface <invalid-interface-name> tartup/shutdown'. * [sonic-utilities] Fix to shutdown and startup on valid PortChannel interface names * [sonic-utilities] Allow shutdown/startup commands to be done using the alias names of PORTs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
config interface PortChannelxxx shutdown
config interface PortChannelxxx startup
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->