-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[db migrator] Introduce the DB migration infrastructure #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add infrastructure to migrate DB contents from a lower version schema to a higher version schema, eventually reach latest version. - if config load_minigraph is executed, the db schema version is always the latest. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
wendani
approved these changes
Apr 20, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve on pfc wd table migration
config reload should also call db_migrator.py -o migtate |
yxieca
commented
Apr 21, 2019
yxieca
commented
Apr 21, 2019
lguohan
approved these changes
Apr 25, 2019
Tested this change (uncommented the pfcwd upgrade), warm reboot from an image before to after worked. |
prsunny
approved these changes
Apr 30, 2019
yxieca
added a commit
that referenced
this pull request
Apr 30, 2019
* [db migrator] Introduce the DB migration infrastructure - Add infrastructure to migrate DB contents from a lower version schema to a higher version schema, eventually reach latest version. - if config load_minigraph is executed, the db schema version is always the latest. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * [db migrator] address issues found in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
to a higher version schema, eventually reach latest version.
the latest.
- How to verify it
Some manual tests.