Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fwutil]: Command-line utility for interacting with platform components #772

Merged
merged 7 commits into from
Feb 20, 2020
Merged

[fwutil]: Command-line utility for interacting with platform components #772

merged 7 commits into from
Feb 20, 2020

Conversation

nazariig
Copy link
Collaborator

Signed-off-by: Nazarii Hnydyn nazariig@mellanox.com

fwutil HLD: sonic-net/SONiC#463

- What I did

  • Introduced fwutil

- How I did it

  • Implemented CLI

- How to verify it

  1. fwutil show status
  2. fwutil install chassis component <component_name> fw <fw_path> -y
  3. fwutil install module <module_name> component <component_name> fw <fw_path> -y
  4. fwutil update -y

- Previous command output (if the output of a command-line utility has changed)

  • N/A

- New command output (if the output of a command-line utility has changed)

  • N/A

@nazariig nazariig mentioned this pull request Dec 18, 2019
Merged
@liat-grozovik
Copy link
Collaborator

retest this please

jleveque
jleveque previously approved these changes Dec 30, 2019
View reviewed changes
@nazariig
Copy link
Collaborator Author

nazariig commented Jan 2, 2020

@sujinmkang please have a look.

@nazariig
Copy link
Collaborator Author

nazariig commented Jan 2, 2020

@lguohan please have a look.

@nazariig nazariig mentioned this pull request Jan 9, 2020
Merged
@nazariig
Copy link
Collaborator Author

nazariig commented Jan 9, 2020

@mudsut4ke please have a look.

srideepDell
srideepDell previously approved these changes Jan 15, 2020
View reviewed changes
@nazariig
Copy link
Collaborator Author

retest this please

4 similar comments
@sujinmkang
Copy link
Collaborator

retest this please

@sujinmkang
Copy link
Collaborator

retest this please

@sujinmkang
Copy link
Collaborator

retest this please

@daall
Copy link
Contributor

daall commented Jan 29, 2020

retest this please

liat-grozovik
liat-grozovik requested changes Jan 29, 2020
View reviewed changes
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing command reference update with the new commands.

@jleveque
Copy link
Contributor

@liat-grozovik: Do we want to add these commands to the Command Reference, or do we intend to wrap these commands in show/config commands?

@nazariig
Copy link
Collaborator Author

nazariig commented Feb 5, 2020 •
edited
Loading

Missing command reference update with the new commands.

@liat-grozovik The CLI reference does not provide the description for the low level tools:
https://github.com/Azure/sonic-utilities/blob/master/doc/Command-Reference.md#introduction
sonic-clear, sfputil, etc., This document does not explain these scripts also.

@nazariig
Copy link
Collaborator Author

nazariig commented Feb 7, 2020

retest this please

jleveque
jleveque suggested changes Feb 7, 2020
View reviewed changes
doc/Command-Reference.md Outdated Show resolved Hide resolved
@jleveque
Copy link
Contributor

Please fix new conflicts.

liat-grozovik
liat-grozovik reviewed Feb 11, 2020
View reviewed changes
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
@nazariig
[fwutil]: initial version.
8c0e02b 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
[fwutil]: Fix UI: enable progressbar render finalizer.
6d2060f 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
[fwutil]: integrate utility with SONiC CLI.
461a609 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
[fwutil]: update CLI command reference documentation.
9751a8e 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
[fwutil]: Revisit CLI architecture: avoid direct imports.
b10d27e 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
[fwutil]: Fix review comments: refactor CLI command reference.
ae1463e 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
[fwutil]: Fix review comments: update CLI documentation.
bf81c6f 
Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
@nazariig
Copy link
Collaborator Author

Please fix new conflicts.

@jleveque done

@jleveque
Copy link
Contributor

LGTM. @sujinmkang to review as well.

@nazariig
Copy link
Collaborator Author

@sujinmkang please have a look

sujinmkang
sujinmkang approved these changes Feb 18, 2020
View reviewed changes
Copy link
Collaborator

@sujinmkang sujinmkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@jleveque
Copy link
Contributor

Merging is blocked because @liat-grozovik has an unresolved requested change.

@liat-grozovik liat-grozovik merged commit 659a935 into sonic-net:master Feb 20, 2020
abdosi pushed a commit that referenced this pull request Feb 24, 2020
@nazariig @abdosi
[fwutil]: Command-line utility for interacting with platform componen…
4e51294 
…ts (#772)

* [fwutil]: initial version.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix UI: enable progressbar render finalizer.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: integrate utility with SONiC CLI.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: update CLI command reference documentation.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Revisit CLI architecture: avoid direct imports.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix review comments: refactor CLI command reference.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix review comments: update CLI documentation.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
@nazariig @abdosi
[fwutil]: Command-line utility for interacting with platform componen…
c7bc25e 
…ts (sonic-net#772)

* [fwutil]: initial version.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix UI: enable progressbar render finalizer.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: integrate utility with SONiC CLI.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: update CLI command reference documentation.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Revisit CLI architecture: avoid direct imports.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix review comments: refactor CLI command reference.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>

* [fwutil]: Fix review comments: update CLI documentation.

Signed-off-by: Nazarii Hnydyn <nazariig@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujinmkang sujinmkang sujinmkang approved these changes

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@jleveque jleveque jleveque approved these changes

@srideepDell srideepDell srideepDell left review comments

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
Enhancement Included in 201911 Branch Request for 201911 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@nazariig @liat-grozovik @sujinmkang @daall @jleveque @srideepDell @abdosi