Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more Python warnings #869

Merged
merged 4 commits into from
Apr 8, 2020
Merged

Fix more Python warnings #869

merged 4 commits into from
Apr 8, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Apr 8, 2020

  • Fix more Python warnings flagged by "LGTM" plugin.

@jleveque jleveque requested a review from lguohan April 8, 2020 02:11
@jleveque jleveque self-assigned this Apr 8, 2020
@lguohan lguohan merged commit a0f3b93 into sonic-net:master Apr 8, 2020
@jleveque jleveque deleted the fix_warnings branch April 8, 2020 06:40
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
@jleveque @abdosi
Fix more Python warnings (sonic-net#869)
86cb844 
* Fix "First parameter of a method is not named 'self'" warnings

* Fix "Module is imported with 'import' and 'import from'" warning

* Fix 'Testing equality to None' warnings

* Clean up 'Unused import' warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

@jleveque jleveque

Labels
Cleanup 💧
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleveque @lguohan