-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to commands config reload/load-minigraph #919
Conversation
load_minigraph command. This will be needed when executed from config-setup script.
4e00f2b
to
b346302
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When adding/removing commands or modifying their names/options/arguments, please also modify docs/CommandReference.md to reflect the changes.
@jleveque Thanks for pointing out. Done |
doc/Command-Reference.md
Outdated
@@ -3269,9 +3269,13 @@ NOTE: Management interface IP address and default route (or specific route) may | |||
When user specifies the optional argument "-y" or "--yes", this command forces the loading without prompting the user for confirmation. | |||
If the argument is not specified, it prompts the user to confirm whether user really wants to load this configuration file. | |||
|
|||
When user specifies the optional argument "-n" or "--no-service-restart", this command loads the configuration without restarting various services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/various services/dependent services/
doc/Command-Reference.md
Outdated
@@ -3304,9 +3308,13 @@ NOTE: Management interface IP address and default route (or specific route) may | |||
When user specifies the optional argument "-y" or "--yes", this command forces the loading without prompting the user for confirmation. | |||
If the argument is not specified, it prompts the user to confirm whether user really wants to load this configuration file. | |||
|
|||
When user specifies the optional argument "-n" or "--no-service-restart", this command clear and loads the configuration without restarting various services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/various services/dependent services/
doc/Command-Reference.md
Outdated
@@ -3304,9 +3308,13 @@ NOTE: Management interface IP address and default route (or specific route) may | |||
When user specifies the optional argument "-y" or "--yes", this command forces the loading without prompting the user for confirmation. | |||
If the argument is not specified, it prompts the user to confirm whether user really wants to load this configuration file. | |||
|
|||
When user specifies the optional argument "-n" or "--no-service-restart", this command clear and loads the configuration without restarting various services | |||
running on the device. One of the use case for this option is during boot time when config-setup service loads exisitng old configuration and there is no services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/One of the use case/One use case/
s/exisitng/existing/
s/there is no services/there are no services/
doc/Command-Reference.md
Outdated
@@ -3269,9 +3269,13 @@ NOTE: Management interface IP address and default route (or specific route) may | |||
When user specifies the optional argument "-y" or "--yes", this command forces the loading without prompting the user for confirmation. | |||
If the argument is not specified, it prompts the user to confirm whether user really wants to load this configuration file. | |||
|
|||
When user specifies the optional argument "-n" or "--no-service-restart", this command loads the configuration without restarting various services | |||
running on the device. One of the use case for this option is during boot time when config-setup service loads minigraph configuration and there is no services |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/One of the use case/One use case/
s/there is no services/there are no services/
* Changes to ignore services stop/start for config reload and load_minigraph command. This will be needed when executed from config-setup script. * Updated Command Reference document * Address Review Comments.
* Changes to ignore services stop/start for config reload and load_minigraph command. This will be needed when executed from config-setup script. * Updated Command Reference document * Address Review Comments.
[201911][show] Fix abbreviations for 'show ip bgp ...' commands (sonic-net#909) Changes to support acl-loader and mirror-session config commands for multi-npu platforms. (sonic-net#908) Changes to commands config reload/load-minigraph (sonic-net#919) Stop/Start restapi server upon config reload (sonic-net#911) [config] Add 'interface transceiver' subgroup with 'lpmode' and 'reset' subcommands (sonic-net#904)
- What I did
Changes to make commands config reload/load-minigraph
to have option of not stop/start docker services. This is not needed
when this commands are called from config-setup shell script. PR: sonic-net/sonic-buildimage#4609 used this change.
- How I did it
Added new option -n (--no-service-restart) with default as False
so that existing command behavior remains same.
- How to verify it
Verified Manually and as well when invoke with config-setup