Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sfpshow][mock_state_db] Tweak key names of some transceiver info fields #958

Merged
merged 1 commit into from
Jun 25, 2020
Merged

[sfpshow][mock_state_db] Tweak key names of some transceiver info fields #958

merged 1 commit into from
Jun 25, 2020

Conversation

jleveque
Copy link
Contributor

Change the following key names:

  • hardwarerev -> hardware_rev
  • serialnum -> serial
  • manufacturename -> manufacturer
  • modelname -> model
  • Connector -> connector

Depends on:

@jleveque jleveque requested a review from keboliu June 23, 2020 20:25
@jleveque jleveque self-assigned this Jun 23, 2020
keboliu
keboliu approved these changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@keboliu keboliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jleveque jleveque requested a review from lguohan June 24, 2020 03:22
@jleveque
Copy link
Contributor Author

Retest this please

@daall
Copy link
Contributor

daall commented Jun 25, 2020

retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque jleveque merged commit fa19b4c into sonic-net:master Jun 25, 2020
@jleveque jleveque deleted the tweak_keys branch June 25, 2020 21:50
abdosi pushed a commit that referenced this pull request Jul 8, 2020
@jleveque @abdosi
[sfpshow][mock_state_db] Tweak key names of some transceiver info fie…
968df0c 
…lds (#958)

Change the following key names:

- hardwarerev -> hardware_rev
- serialnum -> serial
- manufacturename -> manufacturer
- modelname -> model
- Connector -> connector

Depends on:
- sonic-net/sonic-platform-common#97
- sonic-net/sonic-platform-daemons#62
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
@jleveque @abdosi
[sfpshow][mock_state_db] Tweak key names of some transceiver info fie…
c28b057 
…lds (sonic-net#958)

Change the following key names:

- hardwarerev -> hardware_rev
- serialnum -> serial
- manufacturename -> manufacturer
- modelname -> model
- Connector -> connector

Depends on:
- sonic-net/sonic-platform-common#97
- sonic-net/sonic-platform-daemons#62
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
@abdosi
[Submodule update] sonic-utilities
3dcf0ba 
[sfpshow][mock_state_db] Tweak key names of some transceiver info fields
(sonic-net#958)
[config] Fix syntax error (sonic-net#966)
[config] Fix indentation level in _get_disabled_services_list() (sonic-net#965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keboliu keboliu keboliu approved these changes

@yxieca yxieca yxieca approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees

@jleveque jleveque

Labels
Enhancement Included in 201911 Branch Request for 201911 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jleveque @daall @yxieca @keboliu @abdosi