Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonic-installer] Update group name for 'verify-next-image' subcommand #995

Merged
merged 1 commit into from
Jul 19, 2020
Merged

[sonic-installer] Update group name for 'verify-next-image' subcommand #995

merged 1 commit into from
Jul 19, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Jul 17, 2020 •
edited
Loading

Root group name was changed from cli to sonic_installer in #983. However, verify-next-image subcommand was being added in an already-open PR #979 at the time. It did not get updated before merge. This aligns it with the new group name.

@jleveque jleveque requested review from qiluo-msft and rlhui July 17, 2020 17:23
@jleveque jleveque self-assigned this Jul 17, 2020
qiluo-msft
qiluo-msft approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest add test cases to prevent it in future.

@qiluo-msft qiluo-msft requested a review from lguohan July 17, 2020 17:54
@jleveque
Copy link
Contributor Author

@qiluo-msft: I opened a new issue to track this: #996

@jleveque
Copy link
Contributor Author

Retest this please

@lguohan lguohan linked an issue Jul 17, 2020 that may be closed by this pull request
"sonic_installer install " command not working in sonic mainline #997
Closed
@jleveque
Copy link
Contributor Author

Retest this please

8 similar comments
@jleveque
Copy link
Contributor Author

Retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque
Copy link
Contributor Author

Retest this please

@jleveque
Copy link
Contributor Author

The check failures are unrelated to this PR. Since the PR is a bugfix, I am going to merge this in spite of the check failures.

@jleveque jleveque merged commit 82dfe50 into sonic-net:master Jul 19, 2020
@jleveque jleveque deleted the installer_verify_fix branch July 19, 2020 20:40
@jleveque jleveque mentioned this pull request Jul 20, 2020
Merged
jleveque added a commit to sonic-net/sonic-buildimage that referenced this pull request Jul 20, 2020
@jleveque
[sonic-utilities] Update submodule (#5004)
6ef199f 
* src/sonic-utilities a23479e...82dfe50 (3):
  > [sonic-installer] Update group name for 'verify-next-image' subcommand (#/995)
  > [acl_loader] Fix bugs in acl_loader (#991)
  > [show] Add support for QSFP-DD cables on 'show' command (#989)

This submodule update resolves sonic-net/sonic-utilities#997 by including PR sonic-net/sonic-utilities#995
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@rlhui rlhui Awaiting requested review from rlhui

@lguohan lguohan Awaiting requested review from lguohan

Assignees

@jleveque jleveque

Labels
Bug sonic-installer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"sonic_installer install " command not working in sonic mainline
2 participants
@jleveque @qiluo-msft