-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEST] Origin EALink refuses to handshake and therefore starting a game when a specific number of env vars is exceeded! 🤨 #508
Comments
Last time I tried the game worked fine with steamtinkerlaunch (don't have it installed anymore and the download is a bit huge for another test :)) of course it is also possible that above theory is totally unrelated and origin simply botched their installer again :) |
Ah now that you mentioned it I may have installed both Mass Effect and Sims 4 using GE, I've definitely had problem sometimes when doing a first time setup with third party Proton releases. I think Mass Effect Legendary Edition has cloud saves through Origin so it should be safe to try setting up the game again with regular Proton 7.0-3.
I wouldn't be surprised if Origin borked itself haha :-) |
I tried deleting the compatdata, installing Origin with Proton 7.0-3, and then launching again with STL, but the game still crashes, and STL still doesn't display the game info on the Main Menu. It works fine on the Wait Requester and the Crash dialog Not sure where the Main Menu text might be falling over, though that's a more minor issue compared to the game itself not launching. Since deleting the prefix and re-creating it, I now can see the "Connecting to Origin" dialog box when launching with STL, when previously I didn't. I compared the launch behaviour of the game once again when launching with Proton 7.0-3 with and without STL, and there are a couple of differences between these. When launching from Steam, I see:
When launching from STL, the behaviour is different. There is no DirectX installation window, and after the square blank Origin window, a regular Origin window (where I can see opens sometimes even with the Steam Overlay enabled (there is an FPS counter). This stays open for about 5 seconds and then closes, and then about 10-15 seconds later, the STL crash dialog appears. This is how the Origin window that only appears with STL looks: The Origin icon appears in my system tray when launching with and without STL. However it takes significantly longer for Origin to start up with STL if I let the Wait Requester time out. If I click Main Menu and then click Play from there, the game launches with no real noticeable delay in launch speed. Some very strange behaviour here. I realise Mass Effect (and most other Origin games I have) is unreasonably large, so if there's anything I can test or any further logs I can post from my side please let me know (playing Mass Effect for the first time so I'll have it installed for quite a while to test) |
So I found an Origin game in my library that was only 3gb called Unravel, and it has the same behaviour as Mass Effect Legendary Edition and Sims 4 - Exact same sequence with that weird Origin window that only shows up with STL, and the Main Menu is missing the game information. |
nice, means origin changed their launch system again 🙄 |
no real progress yet, but a plan. This is seemingly pretty hard to resolve though, so it won't happen too soon: The plan is to
If everything works well we have a very nice, controllable link2ea implementation when done (and a more robust "Steamworks Shared/evaluatorscript" installation on top)
As steamtinkerlaunch also collects game data from the binary
No nice issue, but interesting and important to fix, so thanks for the report! 👍 |
hm, just removed my previous compatdata and the (already implemented the "manual" launch - totally forgot about it 🙄) evaluator script install worked as expected (maybe the launch recycled |
This is very difficult to debug, as there is no obvious error. the "wait for game exit" function after the game start could close the still running/starting game in theory, for testing I replaced it with a debug function which logs all wine/origin/exe related programs every second after the game launch. this reveals that after ~ 20 seconds the origin launcher stops running and no other exe (the game) is started. not sure how to proceed from here for now... :( |
Compared running processes (and rudimentary Client_Log.txt) between a steamtinkerlaunch and a proton standalone run. I hoped that topic was finally buried, but apparently it is not. |
no it is not just some minor change... |
Wow, thanks for the huge amount of investigation into this! Seems like there's no easy way forward but thank you for the work on this all the time :-) I really have no idea about the Steam Linux Runtime or pressure-vessel but when researching I found some documentation on it on Valve's GitLab:
Maybe there's something useful here? |
thanks, I already used the upstream urls when initially wokring on SLR stuff and already rechecked while debugging again. |
just added some wip functions for further troubleshooting and updated the issue title. |
using the SLR in its up-to-date version would require a version bump from This has multiple consequences, where some of them are difficult to solve correctly:
a very cut down version of steamtinkerlaunch worked with toolmanifest v2 and used the SLR, but wasn't 100% functional because of dependencies not available. Therefore it also wasn't possible to test if this fixed origin compatibility. I guess the only valid way to make steamtinkerlaunch v2 compatible would be some container flavor containing all steamtinkerlaunch files and dependencies. Until toolmanifest v1 still works (assuming it will be shutdown one day) steamtinkerlaunch will stick with it. |
I found something important: bingo: appid 1182480 is EALink
(I guess this is the key to this specific problem, but I'm afraid sooner or later a migration to the mostly closed down toolmanifest v2 container is inevitable) |
when replacing |
Getting closer. When starting a hard-coded
before it works, but doesn't if started after. |
We have a winner! disabling
makes unravel start! |
WTF note for me later: |
Above commit should fix the issue - please test (only tested with unravel here) The $fix is that the new function Fortunately, we were again not affected by the SLR problems mentioned above... fingers crossed |
|
took an insane amount of time to debug and fix this. can you confirm the fix works? |
Sorry this took so long! So Mass Effect still won't launch for me but the behaviour has changed slightly. First off some good news: I can confirm that the Main Menu now correctly shows information about Mass Effect. Thank you so so much for your effort on this! However after the "Connecting to Origin" box, an Origin window sometimes appears that first says something about not being able to install a game from the Origin client, and then suddenly changes to a prompt asking me to select my language/region or something? I can't get it to stay long enough or consistently enough to actually read what it says but the box it shows looks like its asking me to select a region. The window closes after maybe half a second, then the Origin tray icon disappears, and the game closes shortly after. Once the game tries to connect to Origin, the SteamTinkerLaunch tray icon disappears. Could this be anything to do with any potential leftover files somewhere? I removed the Mass Effect Legendary Edition config from I have verified that the game launches without SteamTinkerLaunch. I have attached a steamtinkerlaunch log file. I also tried to create Proton log file, but no such file is generated 😦 I understand SteamTinkerLaunch isn't your priority right now but for completeness please let me know if there are other files I can attach to help debug the issue. |
I only tested the fix with Unravel. The proton logs don't work with origin games, because they do not start the game directly but an url. no idea if this can be changed/fixed. I'll download Mass Effect Legendary and troubleshoot this soonish. |
I just tested Unravel with STL and Proton 7.0-4 and Proton Experimental, and it doesn't launch for me. It has the same behaviour as Mass Effect Legendary Edition.
I got prompted to update Origin with both MELE and and Unravel, should've mentioned that. That's a shame about the logs. I'll see if I can test some other Origin games. |
hm, can you test if unravel works with latest GE? |
Just tried with GE-Proton7-30 and with STL it doesn't work for me, though it works without STL. It has the same behaviour as MELE: "Connecting to Origin", then showing the Origin tray icon and window briefly, then the Origin window disappears, tray icon disappears, and Steam sees that the game is closed (the blue "Stop" button changes back to the green "Play"). MELE doesn't work with GE-Proton7-30, just thought I'd retest it now that I have the latest GE. I installed Sims 4, going to get Origin set up for that game and report back with the results. EDIT: Unfortunately Sims 4 didn't work with STL. Without STL it with Proton Experimental and GE-Proton7-30. I should also note that MELE, Unravel and Sims 4 all correctly show their game information in the Game Menu. |
not sure if you've seen above what the main problem is. |
MELE works fine for me here as well! (fresh install via proton-7.0-4, afterwards switched to steamtinkerlaunch using GE30) for comparison: |
Thanks! So I added that logging. Both env-in and env-out had the
I didn't see anything in |
unsetSTLvars.log only shows the variables which are being unset. just meant to show you what is happening in the background. |
As this seems to be specific to my system I'm happy to close this issue :-) (Trying to help trim down the amount of open issues). Thanks again for all your work on debugging this, sorry it took me so long to get around to testing. Maybe we could put something about this on the wiki too, though I'm not sure how many people are going to run into an issue like this after your fixes. |
I'm not sure if it is specific to your system, but I'm not sure how many people are interested in contributing anything to it 🤨 Sorry I couldn't help you any further. |
It's all good 😄 If it becomes a bigger problem in future and I can fix it I'll submit a PR myself. Closing this now, as I don't think there'll be much further developments with keeping this issue open |
thanks mate! I'll probably close several other issues shortly for the same reason |
When trying to launch Mass Effect Legendary Edition from Steam using SteamTinkerLaunch, I have encountered a few issues.
I've launched the game with and without SteamTinkerLaunch, and the two major differences I can see are:
For some reason, Mass Effect isn't launching properly through STL, and I would wager the "Connecting to Origin" step being missing could be part of the problem. I had a similar problem a while back on my laptop with STL and Sims 4, but I didn't think much of it and just launched without STL, blaming the problem on my laptop. I also remember Sims 4 not displaying any Game Information on the main menu. I would test Sims 4 on my PC now but it's quite a big game and I'm running low on storage space 😞 If anyone else can reproduce this issue with other Origin games please comment as well!
STL Version: v10.0.20220627
Distro: Arch Linux
Desktop: KDE Plasma Wayland
Log file (though I didn't spot anything particularly wrong):
1328670.log
The text was updated successfully, but these errors were encountered: