Remove Depressurizer Support #1029
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonic2kk
force-pushed
the
remove-depressurizer
branch
from
edc7924
to
ffdba94
Compare
sonic2kk
force-pushed
the
remove-depressurizer
branch
2 times, most recently
from
ddf0d67
to
067a692
Compare
|
The current plan is to go forward with this after v14.0. Should probably rebase this regularly to make sure it's ready for merging come the time, just in case. If someone wants to fork and re-add Depressurizer for their own purposes, they should be able to use the diff of this PR to do so. This also needs some more testing to make sure nothing unrelated is broken, so this will stay in draft for a while longer. |
Closed
sonic2kk
added
shellcheck
sonic2kk
force-pushed
the
remove-depressurizer
branch
from
067a692
to
38c5ed9
Compare
sonic2kk
force-pushed
the
remove-depressurizer
branch
from
38c5ed9
to
056100d
Compare
sonic2kk
added
shellcheck
sonic2kk
force-pushed
the
remove-depressurizer
branch
2 times, most recently
from
c9ec1e1
to
ce385c8
Compare
sonic2kk
force-pushed
the
remove-depressurizer
branch
from
ce385c8
to
4fd7aa5
Compare
sonic2kk
force-pushed
the
remove-depressurizer
branch
2 times, most recently
from
f46de23
to
dab7f5b
Compare
sonic2kk
force-pushed
the
remove-depressurizer
branch
from
dab7f5b
to
e58fe73
Compare
sonic2kk
force-pushed
the
remove-depressurizer
branch
from
e58fe73
to
740b61b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for Depressurizer. I do not use this tool or know anything about it, I'm also not sure if anyone uses it with STL. I heard a couple of times in passing in unrelated issues that it doesn't work anymore.
This PR is pretty sweeping and will need testing before it is merged. If someone is using it and/or if someone is vocal about keeping it, then this PR can be closed.
I am not planning to merge this PR until after v14.0. There have been significant changes since the last release, and someone may want to restore Depressurizer support on top of v14.0. Not merging until after release will give a more functional base release to work with restoring and fixing. Of course if anyone does this they're free to merge it back upstream if they are interested in keeping Depressurizer in STL (some people may not be vocal about a change until it is already made).
Opening as a draft as unsure yet if it should be removed. It has also not been tested outside of running a quick ShellCheck.