Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic for fetching MO2 and Vortex version #592

Merged
merged 1 commit into from
Sep 21, 2022
Merged

Fix logic for fetching MO2 and Vortex version #592

merged 1 commit into from
Sep 21, 2022

Commits on Sep 21, 2022

  1. Fix logic for fetching MO2 and Vortex version 

    GitHub changed how assets are loaded on the releases page, they are loaded after the page with lazy loading, so we can't wget on the releases page and get the executable.
Instead, we can get the latest tag version from the release tags page and get the release executable name from the expanded_assets page for that version.
On this page, we can use the previous logic to get the setup executable name.
This solution uses a generic function that works for both MO2 and Vortex. This function only changes how we fetch the latest version for these tools, the actual download logic is the same since that URL did not change.
    @sonic2kk
    sonic2kk committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    1023b55 View commit details
    Browse the repository at this point in the history