Pass External Programs to Custom Command #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still won't properly pass commands as it does not append the values in FINALOUTCMD yet. Also probably won't work for native custom commands.
…MCMD When we enable ONLY_CUSTOMCMD, now GameScope, GameMode and MangoHUD will be enabled. Still need to verify that we do not incorrectly do this on Steam Deck, just to be safe. Also still does not apply to native games. Finally, GameScope does not seem to pass its arguments yet, just the path to GameScope e.g. /usr/bin/gamescope
Still does not apply to native games, but good initial progress for now.
Other langfiles need updated. Still does not apply to native game launches. Probably not all external programs are passed but maybe all that we need to are passed (e.g., is boxtron really required/relevant?) Finally, custom external program args like GameScope are not passed to Wine launches as extWineRun will need refactored for this.
For now it seems like only GameMode is being parsed and passed correctly to native games, but it's a start.
The code for buildCustomCmdLaunch was taken from the first several lines of launchSteamGame, with the launch command array being the only real change. It should be possible to re-use this function instead of having duplicated code.
|
|
|
Seems like we are able to re-use the This PR seems about ready. I will do some more testing and merge soon hopefully. |
This was referenced Feb 2, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639.
When using a custom command with SteamTinkerLaunch, external programs/tools such as GameScope, MangoHud and GameMode are not passed. This PR implements the ability to pass these arguments to custom programs. For example it will now allow you to use Feral GameMode or GameScope with a custom game launcher (e.g. RuneLite for OldSchool RuneScape).
There are currently a handful of outstanding tasks:
Pass external programs to custom programs running with regular Wine as well as ProtonlaunchSteamGameto use a shared function to generate the launch command, if possible (some of the code inbuildCustomCmdLaunchis duplicated)