Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve latest Linux and Windows AMI IDs dynamically #66

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

mgmacias95
Copy link
Collaborator

Issue #, if available:
fixes #65
Description of changes:
I used AWS::SSM::Parameter::Value<AWS::EC2::Image::Id> resource to dynamically fetch AMI IDs 😄 .

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mgmacias95 mgmacias95 added bug Something isn't working enhancement New feature or request aws Related to AWS technologies labels Feb 28, 2019
Copy link
Owner

@sonofagl1tch sonofagl1tch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detlab successfully built 5 times in a row with this new method to choose AMI's. Great work!

@sonofagl1tch sonofagl1tch merged commit ec337e5 into master Feb 28, 2019
@sonofagl1tch sonofagl1tch deleted the fix-hardcoded-amis-v2 branch February 28, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws Related to AWS technologies bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows AMI is outdated
2 participants