-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Apple Vision Pro #223
base: main
Are you sure you want to change the base?
Changes from all commits
9b73747
395db75
615428b
8971f34
65ca515
f7d90c0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -96,7 +96,9 @@ then | |
if [ "$(uname -m)" = "arm64" ]; then | ||
title "••••• Darwin: visionOS simulator tests •••••" | ||
title "boot a simulator" | ||
xcrun simctl list devicetypes vision | ||
xcrun simctl list devices vision | ||
system_profiler SPDeveloperToolsDataType | ||
xcodebuild -showsdks | ||
Comment on lines
+99
to
+101
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. After looking into this a bit, the current default xcode used on the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, this still applies. I can either remove visionOS from the CI matrix or we can wait until the macos runner updates the default xcode. I'm not sure what the xcode versioning policy is (if there is one) on github runners. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about we do all the steps, including creating the simulator and deleting it, but making the steps that fail (presumably just lines 106 or 107) conditional:
|
||
VISIONOS_DEVICE_TYPE=$(xcrun simctl list devicetypes vision -j | jq -r '.devicetypes[0].identifier') | ||
VISIONOS_RUNTIME_ID=$(xcrun simctl list runtimes | grep visionOS | cut -d ' ' -f 7 | tail -1) | ||
export VISIONOS_SIM_ID=$(xcrun simctl create My-apple-vision-pro $VISIONOS_DEVICE_TYPE $VISIONOS_RUNTIME_ID) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you add here:
then before you run the shell script you can add a step:
This is what I've done in my CI.