Updated dependencies #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to all the depedencies I could find except the corefoundation stuff.
simlay
commented
Jan 12, 2020
| @@ -15,15 +16,14 @@ error_chain! { | |||
| description("Cannot compile selected packages for the selected platform") | |||
| display("{:?} cannot be compiled for the selected platform (see project's [package.metadata.dinghy] in Cargo.toml)", packages) | |||
| } | |||
| Cargo(err: ::cargo::CargoError) { | |||
| Cargo(err: String) { | |||
There was a problem hiding this comment.
This could probably be renamed from Cargo because it's technically from failure but given that the cargo crate is the only thing passing up failure errors, it's arguably accurate.
|
thanks for the patch ! release done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only dependency that was bothersome was
cargobecause they upgraded to failure. I was tempted to go all the way to anyhow as they've also done that upgrade.