Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hold back time crate #1131

Merged
merged 4 commits into from
Jul 31, 2023
Merged

hold back time crate #1131

merged 4 commits into from
Jul 31, 2023

Conversation

kali
Copy link
Collaborator

@kali kali commented Jul 31, 2023

No description provided.

@kali kali merged commit 319172e into main Jul 31, 2023
42 checks passed
@kali kali deleted the hold-time-for-1.65 branch August 10, 2023 07:42
@poliorcetics
Copy link

@kali was this related to the project's MSRV ?

@kali
Copy link
Collaborator Author

kali commented Aug 31, 2023

@poliorcetics yes

@Dirreke
Copy link
Contributor

Dirreke commented Oct 18, 2023

Could we use time = "0.3.23" and `time-macros = "0.2.10" ?

Is there any compatibility issues? If not, I think the above is better. Those who use rust 1.65 can use time 0.3.23, while others can use newer time to ensure compatibility with other deps .

@kali
Copy link
Collaborator Author

kali commented Oct 18, 2023

Well, I have no notes or specific memories, but you can assume I put the hold in place because the build was broken. I guess time metadata and cargo version dependencies were conflicting at that point and I have not checked again since. I will increase the MSRV of tract at some (undetermined) point in the future, and at that point I will release all the crate holds, so this is not forever.

What problem are you trying to solve and how bad is it ? If you're convinced your solution works, feel free to make a PR and we can see if the CI is happy with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants