Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/stop using default http client #17

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

KazuhitoNakamura
Copy link
Collaborator

@KazuhitoNakamura KazuhitoNakamura commented Feb 13, 2023

Synchronize the lifetime of a http.Client's connection pool with the lifetime of appsync.Client to avoid waiting for the connection timeout by re-creating the instance if the system network interface has changed.

@KazuhitoNakamura KazuhitoNakamura marked this pull request as ready for review April 5, 2023 00:20
Copy link

@Naoki-Kato Naoki-Kato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KazuhitoNakamura KazuhitoNakamura merged commit 2722996 into master Apr 5, 2023
@KazuhitoNakamura KazuhitoNakamura deleted the feature/stop_using_default_http_client branch April 5, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants