switch the connection lost from string check to error type check. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error message you're receiving, "read tcp 172.20.5.102:50478->15.223.11.251:443: read: operation timed out", indicates a timeout error. This error is typically generated by the underlying Go net library when a network operation exceeds its deadline. In your case, it appears to be a read operation on a TCP connection. Previousy the code,is checking for an error string containing "i/o timeout" to handle connection loss. However, the error message "read: operation timed out" does not match the check. To address this, I modified the error checking to cover more cases. Instead of looking for a specific error string, check for a timeout is using the net.Error interface and its Timeout() method. This approach is generally more reliable and less prone to breakage if the error messages change.
jeremyforan
changed the title
jeremyforan
changed the title
|
Hello, @jeremyforan. Thank you for your Pull Request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the code, is checking for an error string containing "i/o timeout" to handle connection loss. However, the error message "read: operation timed out" does not match the check.
To address this, I modified the error checking to cover more cases. Instead of looking for a specific error string, check for a timeout is using the net.Error interface and its Timeout() method. This approach is generally more reliable and less prone to breakage if the error messages change.
#26 (comment)