Support eglstream #52

ghost · 2021-03-30T05:07:51Z

Description

I add EGLStream backend support. Mouse, touch, and keyboard input are working, but the mouse cursor is not updated when a change notification comes from the flutter. I will support this feature later.

Related issues

#1

src/flutter/shell/platform/linux_embedded/window/native_window_eglstream.cc

ghost · 2021-03-30T05:58:37Z

@HidenoriMatsubayashi Can I request you to review?

HidenoriMatsubayashi

I've commented.

CMakeLists.txt

README.md

src/flutter/shell/platform/linux_embedded/surface/context_egl.h

src/flutter/shell/platform/linux_embedded/surface/environment_egl.h

src/flutter/shell/platform/linux_embedded/surface/linuxes_surface_gl_eglstream.cc

src/flutter/shell/platform/linux_embedded/window/linuxes_window_eglstream.cc

src/flutter/shell/platform/linux_embedded/surface/context_egl.h

ghost · 2021-04-05T04:31:41Z

@HidenoriMatsubayashi I fixed the code. Please review again.

HidenoriMatsubayashi

Can you resolve README conflict first?

CMakeLists.txt

This reverts commit f768b00.

src/flutter/shell/platform/linux_embedded/plugin/mouse_cursor_plugin.cc

src/flutter/shell/platform/linux_embedded/plugin/platform_plugin.cc

src/flutter/shell/platform/linux_embedded/plugin/text_input_plugin.cc

src/flutter/shell/platform/linux_embedded/surface/context_egl_drm_eglstream.h

ghost · 2021-04-05T07:11:37Z

I resolved README conflict.

ghost · 2021-04-07T10:13:04Z

@HidenoriMatsubayashi I fixed the code and merged the latest master branch code. Please review again.

README.md

src/flutter/shell/platform/linux_embedded/plugin/mouse_cursor_plugin.cc

HidenoriMatsubayashi

I checked part of it since there are many bits of advice.

cmake/build.cmake

cmake/package.cmake

examples/flutter-external-texture-plugin/cmake/user_config.cmake

examples/flutter-weston-desktop-shell-virtual-keyboard/cmake/user_config.cmake

src/flutter/shell/platform/linux_embedded/surface/environment_egl_drm_eglstream.h

HidenoriMatsubayashi · 2021-04-07T13:47:01Z

src/flutter/shell/platform/linux_embedded/surface/context_egl_drm_eglstream.h

+
+    EGLint surface_attribs[] = {EGL_WIDTH, window->Width(), EGL_HEIGHT,
+                                window->Height(), EGL_NONE};
+    auto surface = eglCreateStreamProducerSurfaceKHR_(


What happens if the resolution of the display changes in the middle?

If the resolution of the display changes, the display does not update. I will investigate and fix this issue in #65.

src/flutter/shell/platform/linux_embedded/surface/linuxes_surface_gl_drm_eglstream.h

src/flutter/shell/platform/linux_embedded/window/linuxes_window_drm_eglstream.h

src/flutter/shell/platform/linux_embedded/window/linuxes_window_drm_gbm.h

ghost · 2021-04-12T02:35:35Z

@HidenoriMatsubayashi I fixed the code. Please review again. #52 (comment) has not been investigated yet. After investigating, I will update it.

HidenoriMatsubayashi

Please fix these first.

src/flutter/shell/platform/linux_embedded/surface/environment_egl_drm_eglstream.cc

src/flutter/shell/platform/linux_embedded/window/native_window.h

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.h

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.cc

HidenoriMatsubayashi · 2021-04-12T06:08:29Z

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.cc

+  }
+
+  auto map =
+      static_cast<uint8_t*>(mmap(0, create_dump.size, PROT_READ | PROT_WRITE,


There isn't unmap.

I created #71 for this issue.

src/flutter/shell/platform/linux_embedded/window/native_window_drm.h

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.cc

HidenoriMatsubayashi · 2021-04-12T14:38:46Z

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.cc

+
+  struct drm_property_ids property_ids = {0};
+  GetPropertyIds(&property_ids);
+  drmModeAtomicAddProperty(atomic, drm_crtc_->crtc_id,


drmModeAtomicAddProperty returns result.

0 if successful.

-1 if req is NULL or the API is out of memory.

-EINVAL if DRM_CLIENT_CAP_ATOMIC is not enabled.

I created #71 for this issue.

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.cc

ghost · 2021-04-14T09:16:59Z

@HidenoriMatsubayashi I fixed the code. Please review. #52 (comment) and #52 (comment) have not been fixed yet. After investigating, I will fix it.

src/flutter/shell/platform/linux_embedded/surface/context_egl.h

src/flutter/shell/platform/linux_embedded/surface/context_egl_drm_eglstream.cc

src/flutter/shell/platform/linux_embedded/surface/environment_egl.h

src/flutter/shell/platform/linux_embedded/surface/linuxes_surface_gl_drm.h

src/flutter/shell/platform/linux_embedded/window/native_window.h

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.cc

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.h

src/flutter/shell/platform/linux_embedded/window/native_window_drm_gbm.cc

src/flutter/shell/platform/linux_embedded/window/native_window_drm_gbm.h

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.cc

src/flutter/shell/platform/linux_embedded/surface/environment_egl.h

See: - https://github.com/sony/flutter-embedded-linux/releases/tag/fcde2c8b2f - https://github.com/flutter/flutter/tree/flutter-2.5-candidate.5

xMai.Matsuura added 9 commits March 11, 2021 18:44

Merge remote-tracking branch 'upstream/master'

f163cb9

Merge remote-tracking branch 'upstream/master'

fc267c1

Merge remote-tracking branch 'upstream/master'

6ad3367

Merge remote-tracking branch 'upstream/master'

0d59e1a

Merge remote-tracking branch 'upstream/master'

497db10

Merge remote-tracking branch 'upstream/master'

6498e88

Merge remote-tracking branch 'upstream/master'

631076a

Support EGLStream.

f768b00

Fix build error.

da721c6

ghost commented Mar 30, 2021

View reviewed changes

src/flutter/shell/platform/linux_embedded/window/native_window_eglstream.cc Outdated Show resolved Hide resolved

HidenoriMatsubayashi reviewed Mar 30, 2021

View reviewed changes

src/flutter/shell/platform/linux_embedded/surface/context_egl.h Outdated Show resolved Hide resolved

Fix for review.

f06beaa

HidenoriMatsubayashi reviewed Apr 5, 2021

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

xMai.Matsuura added 2 commits April 5, 2021 14:59

Revert "Support EGLStream."

a8fd283

This reverts commit f768b00.

Merge remote-tracking branch 'upstream/master'

956b045

HidenoriMatsubayashi reviewed Apr 5, 2021

View reviewed changes

HidenoriMatsubayashi added the drm Topics of DRM backend label Apr 5, 2021

Merge remote-tracking branch 'origin/master' into support-eglstream

71b7824

xMai.Matsuura added 3 commits April 7, 2021 16:44

Merge remote-tracking branch 'upstream/master'

b17ff6d

Fix for review.

076247c

Merge remote-tracking branch 'origin/master' into support-eglstream

0cd98a6

HidenoriMatsubayashi reviewed Apr 7, 2021

View reviewed changes

README.md Outdated Show resolved Hide resolved

src/flutter/shell/platform/linux_embedded/plugin/mouse_cursor_plugin.cc Outdated Show resolved Hide resolved

HidenoriMatsubayashi reviewed Apr 7, 2021

View reviewed changes

Fix for review.

8c6b973

HidenoriMatsubayashi reviewed Apr 12, 2021

View reviewed changes

src/flutter/shell/platform/linux_embedded/surface/environment_egl_drm_eglstream.cc Show resolved Hide resolved

src/flutter/shell/platform/linux_embedded/window/native_window.h Outdated Show resolved Hide resolved

HidenoriMatsubayashi reviewed Apr 12, 2021

View reviewed changes

Fix for review.

9d99dce

HidenoriMatsubayashi reviewed Apr 14, 2021

View reviewed changes

Fix for review.

424a534

HidenoriMatsubayashi reviewed Apr 15, 2021

View reviewed changes

src/flutter/shell/platform/linux_embedded/window/native_window_drm_eglstream.cc Outdated Show resolved Hide resolved

src/flutter/shell/platform/linux_embedded/surface/environment_egl.h Show resolved Hide resolved

Fix for review.

9750544

ghost mentioned this pull request Apr 15, 2021

Fix EGLStream remaining issues #71

Closed

HidenoriMatsubayashi merged commit a052911 into sony:master Apr 15, 2021

ghost mentioned this pull request Apr 16, 2021

Fix DRM related processing of eglstream. #75

Merged

ghost deleted the support-eglstream branch April 21, 2021 01:42

0	if successful.
-1	if req is NULL or the API is out of memory.
-EINVAL	if DRM_CLIENT_CAP_ATOMIC is not enabled.

Support eglstream #52

Support eglstream #52

Uh oh!

Conversation

ghost commented Mar 30, 2021 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Uh oh!

Uh oh!

ghost commented Mar 30, 2021

Uh oh!

HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Apr 5, 2021

Uh oh!

HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Apr 5, 2021

Uh oh!

ghost commented Apr 7, 2021

Uh oh!

Uh oh!

Uh oh!

HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HidenoriMatsubayashi Apr 7, 2021

Choose a reason for hiding this comment

Uh oh!

ghost Apr 12, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Apr 12, 2021

Uh oh!

HidenoriMatsubayashi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

HidenoriMatsubayashi Apr 12, 2021

Choose a reason for hiding this comment

ghost commented Mar 30, 2021 •

edited by ghost

Loading