New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify bias is not None in GPTQ bias training #1109

Merged

ofirgo merged 1 commit into sony:main from ofirgo:fix-bias-learn-none

Jun 17, 2024

Collaborator

ofirgo commented Jun 17, 2024 •

edited

Loading

Pull Request Description:

GPTQ with bias train is failing in the rare case where a linear layer doesn't have a bias

Checklist before requesting a review:

I set the appropriate labels on the pull request.
I have added/updated the release note draft (if necessary).
I have updated the documentation to reflect my changes (if necessary).
All function and files are well documented.
All function and classes have type hints.
There is a licenses in all file.
The function and variable names are informative.
I have checked for code duplications.
I have added new unittest (if necessary).


          Verify bias is not None in GPTQ bias training

37e8a1c

ofirgo requested a review from reuvenperetz

June 17, 2024 08:20

github-actions bot added the auto:gptq label

reuvenperetz approved these changes

View reviewed changes

Collaborator

reuvenperetz left a comment

Approved. But maybe you should add a unit test for this case (per framework)?

ofirgo merged commit 06fdc8f into sony:main

27 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels