Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/gelu shift negative #1163

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Conversation

yarden-yagil-sony
Copy link
Collaborator

@yarden-yagil-sony yarden-yagil-sony commented Aug 13, 2024

Pull Request Description:

Add GELU activation operator to shift negative substitustions in both keras and pytorch.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Copy link
Collaborator

@Idan-BenAmi Idan-BenAmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: check if you need to modify the mct tests

@ofirgo
Copy link
Collaborator

ofirgo commented Aug 14, 2024

@yardeny-sony, please add a description to the PR, explaining the main changes and possible design choices that were made (if there are such)

@yarden-yagil-sony yarden-yagil-sony merged commit b4c74c8 into main Aug 14, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants