Skip to content

Commit

Permalink
Tweak comments about ST 2110-21 "TP" (type parameter) in the fmtp att…
Browse files Browse the repository at this point in the history
…ribute, to refer to SMPTE ST 2110-20:2017 Section 6.1.1

(update to commit d0deef9)

(cherry picked from commit 90b9d37654eb7d45cac92f95f2fa217c1ff30295)
  • Loading branch information
garethsb committed Apr 29, 2019
1 parent 991630e commit 8d3f05a
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Development/nmos/sdp_utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,7 @@ namespace nmos
// for simplicity, following the order of parameters given in VSF TR-05:2017
// See https://tools.ietf.org/html/rfc4566#section-6
// and http://www.videoservicesforum.org/download/technical_recommendations/VSF_TR-05_2018-06-23.pdf
// and comments regarding the fmtp attribute parameters in get_session_description_sdp_parameters
auto format_specific_parameters = value_of({
sdp::named_value(sdp::fields::width, utility::ostringstreamed(sdp_params.video.width)),
sdp::named_value(sdp::fields::height, utility::ostringstreamed(sdp_params.video.height)),
Expand Down Expand Up @@ -891,10 +892,13 @@ namespace nmos
// don't examine required parameters "PM" (packing mode), "SSN" (SMPTE standard number)
// don't examine optional parameters "segmented", "RANGE", "MAXUDP", "PAR"

// "Senders and Receivers compliant to [ST 2110-20] shall comply with the provisions of SMPTE ST 2110-21."
// See SMPTE ST 2110-20:2017 Section 6.1.1

// See SMPTE ST 2110-21:2017 Section 8.1 Required Parameters
// and Section 8.2 Optional Parameters

// since "TP" (type parameter) is required by ST 2110-21, but not by ST 2110-20, it's effectively optional
// hmm, "TP" (type parameter) is required, but currently omitted by several vendors, so allow that for now...
const auto tp = sdp::find_name(format_specific_parameters, sdp::fields::type_parameter);
if (format_specific_parameters.end() != tp)
{
Expand Down

0 comments on commit 8d3f05a

Please sign in to comment.