Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid raising exception when info has inconsistent values #114

Merged

Conversation

ishihara-y
Copy link
Contributor

Numpy raises error when adding dimensions to an array that has elements of different shapes. (From numpy >= 1.24.0.)

The above change in the numpy library may raise error in codes that worked properly before numpy 1.24.0.

This PR fixes this issue by ignoring the values that has inconsistent shapes when building the batch and alerts the user with warning.

Copy link
Contributor

@TakayoshiTakayanagi TakayoshiTakayanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakayoshiTakayanagi TakayoshiTakayanagi merged commit a8f12f9 into master Nov 30, 2023
11 checks passed
@TakayoshiTakayanagi TakayoshiTakayanagi deleted the feature/20231122-fix-inhomogeneous-array-error branch November 30, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants