Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix improve analysisinputlocation ctors #649

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

swissiety
Copy link
Collaborator

fix #642

@swissiety swissiety requested a review from kadirayk July 21, 2023 07:00
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 89.47% and project coverage change: -0.01% ⚠️

Comparison is base (889b9dd) 64.51% compared to head (275be15) 64.51%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #649      +/-   ##
=============================================
- Coverage      64.51%   64.51%   -0.01%     
+ Complexity      3310     3308       -2     
=============================================
  Files            311      310       -1     
  Lines          14754    14758       +4     
  Branches        2451     2450       -1     
=============================================
+ Hits            9519     9521       +2     
- Misses          4352     4354       +2     
  Partials         883      883              
Files Changed Coverage Δ
...tlocation/JavaModulePathAnalysisInputLocation.java 62.85% <66.66%> (-4.89%) ⬇️
.../sootup/core/inputlocation/EagerInputLocation.java 46.15% <75.00%> (+21.15%) ⬆️
.../inputlocation/PathBasedAnalysisInputLocation.java 70.05% <93.75%> (-0.71%) ⬇️
...utlocation/JavaClassPathAnalysisInputLocation.java 54.83% <100.00%> (ø)
...utlocation/JrtFileSystemAnalysisInputLocation.java 68.47% <100.00%> (+1.43%) ⬆️
...otup/java/bytecode/inputlocation/ModuleFinder.java 77.86% <100.00%> (+0.51%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swissiety swissiety requested a review from stschott July 29, 2023 09:43
@JonasKlauke JonasKlauke merged commit 649c080 into develop Aug 1, 2023
@JonasKlauke JonasKlauke deleted the fix_improve_#642_analysisinputlocation_ctors branch August 1, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix PathBasedAnalysisInputLocation, JavaModuleInfoAnalysisInputLocation constructor
2 participants