Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input locations: check if specified path exists #740

Merged
merged 41 commits into from
Nov 23, 2023

Conversation

swissiety
Copy link
Collaborator

@swissiety swissiety commented Nov 3, 2023

  • add DefaultRTJarAnalysisInputLocation which uses the default Location of the rt.jar via java_home

@swissiety swissiety requested a review from kadirayk November 9, 2023 15:25
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (0d2d469) 63.68% compared to head (888358e) 63.32%.
Report is 2 commits behind head on develop.

Files Patch % Lines
.../inputlocation/PathBasedAnalysisInputLocation.java 68.75% 4 Missing and 1 partial ⚠️
.../sootup/java/core/JavaModuleIdentifierFactory.java 0.00% 5 Missing ⚠️
...src/main/java/sootup/java/core/JavaModuleInfo.java 0.00% 5 Missing ⚠️
...utlocation/JavaClassPathAnalysisInputLocation.java 42.85% 4 Missing ⚠️
...n/java/sootup/java/core/JavaIdentifierFactory.java 57.14% 1 Missing and 2 partials ⚠️
...re/src/main/java/sootup/core/model/SootMethod.java 0.00% 0 Missing and 2 partials ⚠️
...otup/java/bytecode/inputlocation/ModuleFinder.java 60.00% 2 Missing ⚠️
...tlocation/JavaSourcePathAnalysisInputLocation.java 50.00% 1 Missing and 1 partial ⚠️
...in/java/sootup/java/core/views/JavaModuleView.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #740      +/-   ##
=============================================
- Coverage      63.68%   63.32%   -0.36%     
+ Complexity      3342     3331      -11     
=============================================
  Files            317      318       +1     
  Lines          15071    15091      +20     
  Branches        2542     2543       +1     
=============================================
- Hits            9598     9557      -41     
- Misses          4588     4633      +45     
- Partials         885      901      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 22, 2023

You updated the documentation - Doc Preview.

Copy link
Collaborator

@JonasKlauke JonasKlauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JonasKlauke
Copy link
Collaborator

put isConstructor, isStaticInitializer and isMainMethod in a Test to improve the Coverage 😄

@swissiety swissiety merged commit 8169e2d into develop Nov 23, 2023
8 of 9 checks passed
@swissiety swissiety deleted the PathBasedAnalysisInputLocation_path_exists_for_all branch November 23, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants